add moving direction to moving object classification #508
Conversation
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
0815-code
added
FeatureRequest
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
0815-code
force-pushed
the
feature/tp/add_moving_direction_info_#507
branch
from
265b6e2 to
069c58a
Compare
osi_object.proto
Outdated
| { | ||
| // Moving direction is unkown. | ||
| // | ||
| MOVING_DIRECTION_UNKOWN = 1; |
There was a problem hiding this comment.
Start with 0 counting up, that is the reason for the fail i think.
Signed-off-by: Schloemicher, Thomas AVL,AT <thomas.schloemicher@avl.com>
| repeated double assigned_lane_percentage = 2; | ||
| repeated double assigned_lane_percentage = 2; | ||
|
|
||
| // Classification of the general moving direction of a moving object depeding on the relative yaw orientation between host vehicle and moving object. |
There was a problem hiding this comment.
Suggestion:
// Classification of the general moving direction of a moving object depeding on the relative yaw orientation to the host vehicle.
And: what if hostvehicle_id is not set?
|
|
||
| // Moving object is moving in the same direction. | ||
| // | ||
| MOVING_DIRECTION_IN_SAME_DIRECTION = 1; |
There was a problem hiding this comment.
So yaw angle delta -45° to +45°?
|
@ThomasSchloemicherAVL any update from your side on this topic? |
|
OSI CCB 09.05.2022:
|
|
@0815-code Is this still a priority? Can we close this or do you want to work on it? |
|
Closing this PR due to inactivity. Feel free to reopen or create a new one if you'd like to continue the discussion or address the feedback. |
github-project-automation
bot
moved this from Waiting for feedback
to Done
in Sensor Modeling
Signed-off-by: Schloemicher, Thomas AVL,AT thomas.schloemicher@avl.com
#### Reference to a related issue in the repository
Add a reference to a related issue in the repository.
Add a description
Adding moving direction to moving object classification to have a high level sematic information of the overall moving direction of a moving object whether it is oncoming, moving in the same direction or crossing.
Some questions to ask:
What is this change?
What does it fix?
Is this a bug fix or a feature? Does it break any existing functionality or force me to update to a new version?
How has it been tested?
Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:
If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!