-
Notifications
You must be signed in to change notification settings - Fork 131
add moving direction to moving object classification #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -572,7 +572,37 @@ message MovingObject | |
// | ||
// \note OSI uses singular instead of plural for repeated field names. | ||
// | ||
repeated double assigned_lane_percentage = 2; | ||
repeated double assigned_lane_percentage = 2; | ||
|
||
// Classification of the general moving direction of a moving object depeding on the relative yaw orientation between host vehicle and moving object. | ||
// TODOD Maybe add grafic to illustrate the situation with relative yaw angle | ||
// | ||
optional MovingDirection moving_direction = 3; | ||
|
||
// Definitions of moving direction. | ||
// | ||
enum MovingDirection | ||
{ | ||
// Moving direction is unkown. | ||
// | ||
MOVING_DIRECTION_UNKOWN = 1; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Start with 0 counting up, that is the reason for the fail i think. |
||
|
||
// Moving object is moving in the same direction. | ||
// | ||
MOVING_DIRECTION_IN_SAME_DIRECTION = 2; | ||
|
||
// Moving object is moving towards the host vehicle. | ||
// | ||
MOVING_DIRECTION_ONCOMING = 3; | ||
|
||
// Moving object is crossing from left to right. | ||
// | ||
MOVING_DIRECTION_CROSSING_LEFT_TO_RIGHT = 4; | ||
|
||
// Moving object is crossing from right to left. | ||
// | ||
MOVING_DIRECTION_CROSSING_RIGHT_TO_LEFT = 5; | ||
} | ||
} | ||
|
||
// | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depending
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion:
// Classification of the general moving direction of a moving object depeding on the relative yaw orientation to the host vehicle.
And: what if hostvehicle_id is not set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ThomasSchloemicherAVL please comment