Skip to content

Added coordinate transformation to documentation #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 2, 2022
Merged

Added coordinate transformation to documentation #607

merged 3 commits into from
May 2, 2022

Conversation

LukasElster
Copy link
Contributor

Signed-off-by: @lukas.elster lukas.elster@tu-darmstadt.de

#### Reference to a related issue in the repository
Resolves #604

Add a description

Added a explanation of the coordinate transformation in general and between the OSI coordinate systems. I tested the changes via a local build with asciidoctor.

Take this checklist as orientation for yourself, if this PR is ready for the Change Control Board:

  • My suggestion follows the style and contributors guidelines.
  • I have taken care about the documentation.
  • I have done the DCO signoff.
  • My changes generate no errors when passing CI tests.
  • I have successfully implemented and tested my fix/feature locally.
  • Appropriate reviewer(s) are assigned.

If you can’t check all of them, please explain why.
If all boxes are checked or commented and you have achieved at least one positive review, you can assign the label ReadyForCCBReview!

@LukasElster
Added coordinate transformation to documentation
a696c7a 
Signed-off-by: @lukas.elster <lukas.elster@tu-darmstadt.de>
@LukasElster LukasElster added the Documentation Everything which impacts the quality of the documentation and guidelines. label Jan 11, 2022
@LukasElster LukasElster added this to the V3.5.0 milestone Jan 11, 2022
@LukasElster LukasElster self-assigned this Jan 11, 2022
@LukasElster
Bugfix in citation
3606291 
Signed-off-by: @lukas.elster <lukas.elster@tu-darmstadt.de>
@PhRosenberger PhRosenberger mentioned this pull request Jan 19, 2022
Closed
stefancyliax
stefancyliax reviewed Apr 14, 2022
View reviewed changes
Copy link
Contributor

@stefancyliax stefancyliax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax side looks good. But I can't review the actual content.
Going to add the ReadyForCCB label

@stefancyliax stefancyliax added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Apr 14, 2022
@kmeids
Copy link

kmeids commented Apr 25, 2022

Output CCB 25.04.2022

  1. @pmai, could you please approve and merge?

@kmeids kmeids added ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB. and removed ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. labels Apr 25, 2022
@pmai pmai merged commit 5c44f27 into master May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefancyliax stefancyliax stefancyliax left review comments

@pmai pmai pmai approved these changes

Assignees

@LukasElster LukasElster

Labels
Documentation Everything which impacts the quality of the documentation and guidelines. ReadyToMerge This PR has been approved to merge and will be merged by a member of the CCB.
Projects
None yet
Milestone
V3.5.0
Development

Successfully merging this pull request may close these issues.

Add coordinate transformation in documentation
4 participants
@LukasElster @kmeids @pmai @stefancyliax