From 3b48a48d2a775be6746cfdd97f9a3abbdbd5afa9 Mon Sep 17 00:00:00 2001 From: Thomas Nader Date: Wed, 13 Apr 2022 09:34:44 +0200 Subject: [PATCH 1/6] Introducing Operating States The operating state of the vehicle. Signed-off-by: Thomas Nader --- osi_hostvehicledata.proto | 35 +++++++++++++++++++++++++++++++++-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/osi_hostvehicledata.proto b/osi_hostvehicledata.proto index 7049cc4c7..8914f0358 100644 --- a/osi_hostvehicledata.proto +++ b/osi_hostvehicledata.proto @@ -51,7 +51,7 @@ message HostVehicleData // optional BaseMoving location_rmse = 2; - // The basic parameters of the vehicle. + // The basic parameters and overall states of the vehicle. // optional VehicleBasics vehicle_basics = 3; @@ -88,7 +88,7 @@ message HostVehicleData repeated VehicleAutomatedDrivingFunction vehicle_automated_driving_function = 12; // - // \brief The absolute base parameters of the vehicle. + // \brief Base parameters and overall states of the vehicle. // message VehicleBasics { @@ -100,6 +100,37 @@ message HostVehicleData // Paragraph 42 of the German Road Traffic Admission Regulations (StVZO). // optional double curb_weight = 1; + + // The operating status of the vehicle. + // + optional OperatingStatus operating_status = 2; + + // Possible operating stati of the vehicle. + // + enum OperatingStatus + { + // The operating status is unknown. + // + OPERATING_STATUS_UNKNOWN = 0; + + // The operating status is another one. + // + OPERATING_STATUS_OTHER = 1; + + // The minimum electrical state the vehicle reaches after a while. + // Usually the driver has left the car a few hours ago. + // + OPERATING_STATUS_OFF = 2; + + // Some electrical consumers are operating e.g. interior lights or radio. + // Usually the driver sits in the car before or after a drive. + // + OPERATING_STATUS_READY = 3; + + // The electrical state that is necessary to drive the vehicle. + // + OPERATING_STATUS_ON = 4; + } } // From d0e8141fca725b85fb4a0ba6d2aa4d601f19bb17 Mon Sep 17 00:00:00 2001 From: Thomas Nader Date: Tue, 26 Apr 2022 17:27:36 +0200 Subject: [PATCH 2/6] State instead of status State instead of status. Signed-off-by: Thomas Nader --- osi_hostvehicledata.proto | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/osi_hostvehicledata.proto b/osi_hostvehicledata.proto index 8914f0358..b4043ab28 100644 --- a/osi_hostvehicledata.proto +++ b/osi_hostvehicledata.proto @@ -101,35 +101,35 @@ message HostVehicleData // optional double curb_weight = 1; - // The operating status of the vehicle. + // The operating state of the vehicle. // - optional OperatingStatus operating_status = 2; + optional OperatingState operating_state = 2; - // Possible operating stati of the vehicle. + // Possible operating states of the vehicle. // enum OperatingStatus { - // The operating status is unknown. + // The operating state is unknown. // - OPERATING_STATUS_UNKNOWN = 0; + OPERATING_STATE_UNKNOWN = 0; - // The operating status is another one. + // The operating state is another one. // - OPERATING_STATUS_OTHER = 1; + OPERATING_STATE_OTHER = 1; // The minimum electrical state the vehicle reaches after a while. // Usually the driver has left the car a few hours ago. // - OPERATING_STATUS_OFF = 2; + OPERATING_STATE_OFF = 2; // Some electrical consumers are operating e.g. interior lights or radio. // Usually the driver sits in the car before or after a drive. // - OPERATING_STATUS_READY = 3; + OPERATING_STATE_READY = 3; // The electrical state that is necessary to drive the vehicle. // - OPERATING_STATUS_ON = 4; + OPERATING_STATE_ON = 4; } } From 59c99bda1c80d1920b1d901df79bc75ef4b9d774 Mon Sep 17 00:00:00 2001 From: Thomas Nader Date: Tue, 26 Apr 2022 17:28:44 +0200 Subject: [PATCH 3/6] Update osi_hostvehicledata.proto One more state instead of status Signed-off-by: Thomas Nader --- osi_hostvehicledata.proto | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/osi_hostvehicledata.proto b/osi_hostvehicledata.proto index b4043ab28..584284393 100644 --- a/osi_hostvehicledata.proto +++ b/osi_hostvehicledata.proto @@ -107,7 +107,7 @@ message HostVehicleData // Possible operating states of the vehicle. // - enum OperatingStatus + enum OperatingState { // The operating state is unknown. // From bdcaeae73b71b2a0d769a94d557688c85bdf8619 Mon Sep 17 00:00:00 2001 From: Thomas Nader Date: Thu, 28 Apr 2022 16:47:46 +0200 Subject: [PATCH 4/6] Extension of possible states Extension of possible states. Signed-off-by: Thomas Nader --- osi_hostvehicledata.proto | 33 +++++++++++++++++++++++++-------- 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/osi_hostvehicledata.proto b/osi_hostvehicledata.proto index 584284393..26e173398 100644 --- a/osi_hostvehicledata.proto +++ b/osi_hostvehicledata.proto @@ -101,11 +101,11 @@ message HostVehicleData // optional double curb_weight = 1; - // The operating state of the vehicle. + // The operating state of the vehicle from an user's perspective. // optional OperatingState operating_state = 2; - // Possible operating states of the vehicle. + // Possible operating states of the vehicle from an user's perspective. // enum OperatingState { @@ -117,19 +117,36 @@ message HostVehicleData // OPERATING_STATE_OTHER = 1; - // The minimum electrical state the vehicle reaches after a while. - // Usually the driver has left the car a few hours ago. + // The minimum electrical state of the vehicle (and its ECUs). + // Usually the driver has left the car a while ago. // - OPERATING_STATE_OFF = 2; + OPERATING_STATE_SLEEP = 2; - // Some electrical consumers are operating e.g. interior lights or radio. + // Cabin lights and entertainment are off. The vehicle can not be driven. + // Some ECUs are still operating and not in their minimum electrical sate. + // Usually the driver has left the car recently. + // + OPERATING_STATE_OFF = 3; + + // Some features of the vehicle are available e.g. cabin lights. + // Entertainment is off and the vehicle can not be driven. + // Usually the driver wants to enter or leave the car. + // + OPERATING_STATE_BOARDING = 4; + + // Entertainment, navigation or similiar systems can be used by the driver. + // The vehicle can not be driven. // Usually the driver sits in the car before or after a drive. // - OPERATING_STATE_READY = 3; + OPERATING_STATE_ENTERTAINMENT = 5; // The electrical state that is necessary to drive the vehicle. // - OPERATING_STATE_ON = 4; + OPERATING_STATE_DRIVING = 6; + + // The electrical state that is necessary for analysis and diagnostics. + // + OPERATING_STATE_DIAGNOSTIC = 7; } } From d375a9e04d239757fa1ba4421ea5b714fe8b07d4 Mon Sep 17 00:00:00 2001 From: Thomas Nader Date: Thu, 28 Apr 2022 16:53:27 +0200 Subject: [PATCH 5/6] vehicle instead of car vehicle instead of car Signed-off-by: Thomas Nader --- osi_hostvehicledata.proto | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/osi_hostvehicledata.proto b/osi_hostvehicledata.proto index 26e173398..968a4c093 100644 --- a/osi_hostvehicledata.proto +++ b/osi_hostvehicledata.proto @@ -101,11 +101,11 @@ message HostVehicleData // optional double curb_weight = 1; - // The operating state of the vehicle from an user's perspective. + // The operating state of the vehicle. // optional OperatingState operating_state = 2; - // Possible operating states of the vehicle from an user's perspective. + // Possible operating states of the vehicle. // enum OperatingState { @@ -118,25 +118,25 @@ message HostVehicleData OPERATING_STATE_OTHER = 1; // The minimum electrical state of the vehicle (and its ECUs). - // Usually the driver has left the car a while ago. + // Usually the driver has left the vehicle a while ago. // OPERATING_STATE_SLEEP = 2; // Cabin lights and entertainment are off. The vehicle can not be driven. // Some ECUs are still operating and not in their minimum electrical sate. - // Usually the driver has left the car recently. + // Usually the driver has left the vehicle recently. // OPERATING_STATE_OFF = 3; // Some features of the vehicle are available e.g. cabin lights. // Entertainment is off and the vehicle can not be driven. - // Usually the driver wants to enter or leave the car. + // Usually the driver wants to enter or leave the vehicle. // OPERATING_STATE_BOARDING = 4; // Entertainment, navigation or similiar systems can be used by the driver. // The vehicle can not be driven. - // Usually the driver sits in the car before or after a drive. + // Usually the driver sits in the vehicle before or after a drive. // OPERATING_STATE_ENTERTAINMENT = 5; From 46b48ef4fae9f59758584a234c45824671632ae8 Mon Sep 17 00:00:00 2001 From: Thomas Nader Date: Wed, 11 May 2022 10:33:11 +0200 Subject: [PATCH 6/6] STATE_STANDBY instead of STATE_OFF STATE_STANDBY instead of STATE_OFF and description extension. Signed-off-by: Thomas Nader --- osi_hostvehicledata.proto | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/osi_hostvehicledata.proto b/osi_hostvehicledata.proto index 968a4c093..78e7095a3 100644 --- a/osi_hostvehicledata.proto +++ b/osi_hostvehicledata.proto @@ -106,6 +106,7 @@ message HostVehicleData optional OperatingState operating_state = 2; // Possible operating states of the vehicle. + // It is user specific which states are used and how their transitions work. // enum OperatingState { @@ -124,9 +125,9 @@ message HostVehicleData // Cabin lights and entertainment are off. The vehicle can not be driven. // Some ECUs are still operating and not in their minimum electrical sate. - // Usually the driver has left the vehicle recently. + // Usually the driver has left (and closed) the vehicle recently. // - OPERATING_STATE_OFF = 3; + OPERATING_STATE_STANDBY = 3; // Some features of the vehicle are available e.g. cabin lights. // Entertainment is off and the vehicle can not be driven.