From 921754854b9e37f3d2ca3e6cbcf216ab7a323339 Mon Sep 17 00:00:00 2001 From: Fabian Pfeuffer Date: Fri, 20 May 2022 10:44:00 +0200 Subject: [PATCH 1/2] Concretize lane boundary modelling for lanes at different heights * Added additional documentation on how the boundary between lanes at different heights should be modeled. Signed-off-by: Fabian Pfeuffer --- osi_lane.proto | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/osi_lane.proto b/osi_lane.proto index 9f14fcb39..b65c46600 100644 --- a/osi_lane.proto +++ b/osi_lane.proto @@ -323,6 +323,12 @@ message Lane // // \note OSI uses singular instead of plural for repeated field names. // + // \note The boundary between adjacent lanes at different heights + // (e.g. a curb between a driving lane and a sidewalk) + // should not be shared, but modeled as two separate lane + // boundaries with individual ids. One for the upper, the + // other one for the lower lane. + // // \rules // check_if this.type is_different_to 4 else do_check is_set // \endrules @@ -344,6 +350,12 @@ message Lane // // \note OSI uses singular instead of plural for repeated field names. // + // \note The boundary between adjacent lanes at different heights + // (e.g. a curb between a driving lane and a sidewalk) + // should not be shared, but modeled as two separate lane + // boundaries with individual ids. One for the upper, the + // other one for the lower lane. + // // \rules // check_if this.type is_different_to 4 else do_check is_set // \endrules @@ -813,6 +825,16 @@ message LaneBoundary // \image html OSI_LaneBoundaryHeight.svg "" width=600px // // \note Field need not be set if it is previously defined. + // + // \note The boundary point height should not be used to model the boundary + // between two adjacent lanes at different heights as a single, shared + // boundary. + // Boundaries between adjacent lanes at different heights should be + // modeled as two separate lane boundaries. The height attribute of the + // lower boundary points will be the difference in height between + // the upper and the lower boundary at the point's position. + // The height attribute of the upper boundary points will be zero. + // // See \c LaneBoundary . // optional double height = 3; From 9a02801a89c0e3ff2be8a6b3d9ab7cd4e8a72aca Mon Sep 17 00:00:00 2001 From: "Pierre R. Mai" Date: Mon, 30 May 2022 14:10:22 +0200 Subject: [PATCH 2/2] Remove comments on height attribute for lane boundaries Co-authored-by: Stefan Cyliax Signed-off-by: Pierre R. Mai --- osi_lane.proto | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/osi_lane.proto b/osi_lane.proto index b65c46600..062eb6a00 100644 --- a/osi_lane.proto +++ b/osi_lane.proto @@ -830,10 +830,7 @@ message LaneBoundary // between two adjacent lanes at different heights as a single, shared // boundary. // Boundaries between adjacent lanes at different heights should be - // modeled as two separate lane boundaries. The height attribute of the - // lower boundary points will be the difference in height between - // the upper and the lower boundary at the point's position. - // The height attribute of the upper boundary points will be zero. + // modeled as two separate lane boundaries. // // See \c LaneBoundary . //