Skip to content

Fix open_simulation_interface-config.cmake.in #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2025
Merged

Fix open_simulation_interface-config.cmake.in #852

merged 1 commit into from
Apr 10, 2025

Conversation

doganulus
Copy link
Contributor

@doganulus doganulus commented Feb 5, 2025 •
edited
Loading

The corresponding filename in the patch must be the same as this filename

When using CMake's find_package to use the library in another project, the mismatch between filenames results in an error.

@jdsika jdsika requested a review from pmai February 24, 2025 15:20
@jdsika jdsika added BreaksCompatibility Initial expectation is that backward compatibility needs to be broken Bug Problems in the build system, build scripts, etc or faults in the interface. and removed BreaksCompatibility Initial expectation is that backward compatibility needs to be broken labels Feb 24, 2025
@pmai pmai added the ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB. label Apr 10, 2025
pmai
pmai approved these changes Apr 10, 2025
View reviewed changes
Copy link
Contributor

@pmai pmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, should be applied.

@pmai pmai added this to the V3.7.1 milestone Apr 10, 2025
@yash-shah-asam
Copy link
Member

yash-shah-asam commented Apr 10, 2025 •
edited
Loading

ASAM OSI CCB 2025-04-10: Approved and assigned to v3.7.1 and ready to be merged.

@pmai pmai merged commit 3af2351 into OpenSimulationInterface:master Apr 10, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmai pmai pmai approved these changes

Assignees
No one assigned
Labels
Bug Problems in the build system, build scripts, etc or faults in the interface. ReadyForCCBReview Indicates that this MR is ready for a final review and merge by the CCB.
Projects
None yet
Milestone
V3.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@doganulus @yash-shah-asam @pmai @jdsika