-
Notifications
You must be signed in to change notification settings - Fork 1
Feature/add checkboxes for search #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
src/components/FilterList/SearchSettingsMenu/FilterListSearchSettingsMenu.tsx
Outdated
Show resolved
Hide resolved
src/components/FilterList/SearchSettingsMenu/FilterListSearchSettingsMenu.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a filterlist component to allow users to toggle which keys are used when searching through various data collections. The key changes include:
- Introducing and integrating the useSearchKeySettings hook to manage search keys across multiple panels.
- Updating matcher function calls to use dynamic key selections from the hook.
- Enhancing various UI elements such as dropdown widths, button groups, and icon replacements to streamline the search experience.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/util/text.ts | Added helper function to convert camelCase to regular text. |
| src/types/types.ts | Added new KeybindInfoType for type composition. |
| src/panels/SkyBrowserPanel/ImageList/ImageList.tsx | Integrated search key management and updated matcher function usage. |
| src/panels/Scene/SceneTree/SceneTreeFilters.tsx | Adjusted UI for filters with increased dropdown width and added labels. |
| src/panels/Scene/SceneTree/SceneTree.tsx | Updated search settings integration to use dynamic keys. |
| src/panels/NavigationPanel/NavigationPanel.tsx | Replaced hard-coded matcher function keys with dynamic ones from the hook. |
| src/panels/NavigationPanel/FocusView/FocusView.tsx | Updated component to accept toggleKey and allowedKeys for search settings. |
| src/panels/NavigationPanel/AnchorAimView/AnchorAimView.tsx | Updated component to accept search settings props. |
| src/panels/KeybindsPanel/ListLayout.tsx | Replaced matcher function keys with selectedSearchKeys and updated import types. |
| src/panels/GeoLocationPanel/AnchorPanels/EarthPanel/EarthPanel.tsx | Added and integrated search settings for geolocation filtering. |
| src/panels/ActionsPanel/ActionsPanel.tsx | Updated search matcher functions and integrated search settings UI. |
| src/icons/icons.tsx | Added WarningIcon for use in other components. |
| src/components/Input/NumericInput/NumericInput.tsx | Replaced outdated icon with WarningIcon in the numeric input component. |
| src/components/FilterList/SearchSettingsMenu/hook.ts | Introduced custom hook for managing search key settings. |
| src/components/FilterList/SearchSettingsMenu/FilterListSearchSettingsMenu.tsx | Added search settings menu UI for toggling search keys. |
| src/components/FilterList/SearchResults/SearchResults.tsx | Optimized memoization of filtered items for an empty search string. |
| src/components/FilterList/FilterListInputField.tsx | Added flex property for layout consistency. |
| src/components/FilterList/FilterList.tsx | Integrated the new SearchSettingsMenu into the FilterList component. |
src/components/FilterList/SearchSettingsMenu/FilterListSearchSettingsMenu.tsx
Outdated
Show resolved
Hide resolved
WeirdRubberDuck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Essentially an approve, but I had some comments on the template and keyof T situation. Let's discuss
# Conflicts: # src/panels/Scene/SceneTree/SceneTreeFilters.tsx
Co-authored-by: Emma Broman <emma.broman@liu.se>
Adds a filterlist component for checking which keys should be searched in the object.
Added it to all places we have the
generateMatcherFunction