Skip to content

Conversation

@ylvaselling
Copy link
Collaborator

Adds a filterlist component for checking which keys should be searched in the object.

Added it to all places we have the generateMatcherFunction

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a filterlist component to allow users to toggle which keys are used when searching through various data collections. The key changes include:

  • Introducing and integrating the useSearchKeySettings hook to manage search keys across multiple panels.
  • Updating matcher function calls to use dynamic key selections from the hook.
  • Enhancing various UI elements such as dropdown widths, button groups, and icon replacements to streamline the search experience.

Reviewed Changes

Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/util/text.ts Added helper function to convert camelCase to regular text.
src/types/types.ts Added new KeybindInfoType for type composition.
src/panels/SkyBrowserPanel/ImageList/ImageList.tsx Integrated search key management and updated matcher function usage.
src/panels/Scene/SceneTree/SceneTreeFilters.tsx Adjusted UI for filters with increased dropdown width and added labels.
src/panels/Scene/SceneTree/SceneTree.tsx Updated search settings integration to use dynamic keys.
src/panels/NavigationPanel/NavigationPanel.tsx Replaced hard-coded matcher function keys with dynamic ones from the hook.
src/panels/NavigationPanel/FocusView/FocusView.tsx Updated component to accept toggleKey and allowedKeys for search settings.
src/panels/NavigationPanel/AnchorAimView/AnchorAimView.tsx Updated component to accept search settings props.
src/panels/KeybindsPanel/ListLayout.tsx Replaced matcher function keys with selectedSearchKeys and updated import types.
src/panels/GeoLocationPanel/AnchorPanels/EarthPanel/EarthPanel.tsx Added and integrated search settings for geolocation filtering.
src/panels/ActionsPanel/ActionsPanel.tsx Updated search matcher functions and integrated search settings UI.
src/icons/icons.tsx Added WarningIcon for use in other components.
src/components/Input/NumericInput/NumericInput.tsx Replaced outdated icon with WarningIcon in the numeric input component.
src/components/FilterList/SearchSettingsMenu/hook.ts Introduced custom hook for managing search key settings.
src/components/FilterList/SearchSettingsMenu/FilterListSearchSettingsMenu.tsx Added search settings menu UI for toggling search keys.
src/components/FilterList/SearchResults/SearchResults.tsx Optimized memoization of filtered items for an empty search string.
src/components/FilterList/FilterListInputField.tsx Added flex property for layout consistency.
src/components/FilterList/FilterList.tsx Integrated the new SearchSettingsMenu into the FilterList component.

Copy link
Collaborator

@WeirdRubberDuck WeirdRubberDuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Essentially an approve, but I had some comments on the template and keyof T situation. Let's discuss

# Conflicts:
#	src/panels/Scene/SceneTree/SceneTreeFilters.tsx
ylvaselling and others added 2 commits April 28, 2025 14:14
Co-authored-by: Emma Broman <emma.broman@liu.se>
@ylvaselling ylvaselling merged commit 39c2689 into master Apr 29, 2025
@ylvaselling ylvaselling deleted the feature/add-checkboxes-for-search branch April 29, 2025 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants