-
Notifications
You must be signed in to change notification settings - Fork 0
Feature/unify task bar #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
# Conflicts: # src/redux/local/localSlice.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was convenient to try the loading states, since the UI in this branch does not load correctly when used with the later 2025-ui-rewrite
branch 😉 The loading states look great
Some TODOs
- We should also make sure to remove the "enabled" settings from the taskbar settings in the engine right away, so that that is not forgotten.
- Let's add loading blocks to the Settings menu and Actions as well?
- I don't think the loading of the
default_ui_panels.json
work anymore? Or the problem that this UI branch is not up to date with master? The reason I'm asking is that the Exoplanets and SkyBrowser should be visible per default according to that file, as well as some other panels
Regarding 3 - let me know if you observe the same behavior (so that it's not just something with my setup that breaks it)
Co-authored-by: Emma Broman <emma.broman@liu.se>
enabled
property for menu items