Remove colonies from admin efficiency #486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
reviewed
Jul 7, 2025
|
Could the PR and commit message be |
wvpm
changed the title
wvpm
force-pushed
the
exclude_colonies_for_admin_eff
branch
2 times, most recently
from
b6f2d5e to
c97558d
Compare
Spartan322
force-pushed
the
exclude_colonies_for_admin_eff
branch
from
c97558d to
030dfdd
Compare
Spartan322
approved these changes
Jul 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colonial states are excluded for national administrative efficiency calculation.
Note that there still is a difference with Victoria 2. The difference is significantly reduced with this change though.