Expose vector properties via span #511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When its not a reference, we do |
Spartan322
reviewed
Jul 29, 2025
Spartan322
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead
get_##NAME()returning avector<T> const&it now returns aforwardable_span<const T>.This ensures the collection is const, but if T is a pointer to a non-const type, the instance it points to is non-const.
This is required for #508 as it requires non-const instances to get data that may update a cache.
If desired, the forwardable_span return could be exposed as non-const with the
vector<T> const&remaining as const variant.That would result in different return types between const and non-const
get_##NAME().