Skip to content

Mass clean up of includes #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2025
Merged

Mass clean up of includes #514

merged 1 commit into from
Aug 1, 2025

Conversation

wvpm
Copy link
Contributor

@wvpm wvpm commented Jul 31, 2025 •
edited
Loading

  • Moved type aliases into their own file.
  • Moved reused macro UNIT_BRANCHED_GETTER into its own file.
  • Forward declare types when possible.
  • Converted constexpr methods to normal methods when they require type imports.
  • Split Issue into PartyPolicy & Reform (both inherit from BaseIssue). This fixes HasIndex overlap.

@wvpm wvpm added topic:codestyle enhancement New feature or request labels Jul 31, 2025
@wvpm wvpm added this to the 0.9.0 milestone Jul 31, 2025
@wvpm wvpm force-pushed the clean_up_includes branch from 9b98bce to 3767001 Compare July 31, 2025 14:15
@wvpm wvpm enabled auto-merge July 31, 2025 14:22
@wvpm wvpm force-pushed the clean_up_includes branch 10 times, most recently from 2a8b97a to b9a9cb8 Compare August 1, 2025 09:15
@wvpm wvpm added the topic:core label Aug 1, 2025
@wvpm wvpm force-pushed the clean_up_includes branch 3 times, most recently from d86506e to a00082d Compare August 1, 2025 12:11
Spartan322
Spartan322 reviewed Aug 1, 2025
View reviewed changes
@wvpm wvpm force-pushed the clean_up_includes branch 3 times, most recently from 0714894 to af680cd Compare August 1, 2025 13:22
@wvpm wvpm force-pushed the clean_up_includes branch from af680cd to 49a07ea Compare August 1, 2025 13:25
@wvpm wvpm merged commit f1ecdf5 into master Aug 1, 2025
14 checks passed
@wvpm wvpm deleted the clean_up_includes branch August 1, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spartan322 Spartan322 Spartan322 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request topic:codestyle topic:core
Projects
None yet
Milestone
0.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@wvpm @Spartan322