Move Mod dependency generator to Mod class #551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spartan322
added
enhancement
Spartan322
force-pushed
the
move/mod-dep-list
branch
2 times, most recently
from
83006e7 to
217a330
Compare
Add mod_manager property to Mod class
Spartan322
force-pushed
the
move/mod-dep-list
branch
from
217a330 to
0938d04
Compare
wvpm
reviewed
Sep 2, 2025
|
|
||
| struct Mod : HasIdentifier { | ||
| private: | ||
| ModManager const& PROPERTY(mod_manager); |
There was a problem hiding this comment.
Suggested change
| ModManager const& PROPERTY(mod_manager); | |
| ModManager const& mod_manager; |
It should not expose mod manager publicly.
wvpm
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mod_manager property to Mod class