Skip to content

Commit 019969c

Browse files
author
nitrocaster
committed
xrRender_GL: Fix conformance in For loop scope (#104).
1 parent 46cadde commit 019969c

File tree

10 files changed

+16
-14
lines changed

10 files changed

+16
-14
lines changed

src/Layers/xrRender/D3DUtils.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ void CDrawUtilities::UpdateGrid(int number_of_cell, float square_size, int subdi
170170
m_GridPoints.push_back( right );
171171
}
172172
}
173-
for(i=-m_GridCounts[1]; i<=m_GridCounts[1]; i++){
173+
for(int i=-m_GridCounts[1]; i<=m_GridCounts[1]; i++){
174174
if( (!!thin) != !!(i%m_GridSubDiv[1]) ){
175175
left.p.x = -m_GridCounts[0]*m_GridStep.x;
176176
right.p.x = m_GridCounts[0]*m_GridStep.x;
@@ -216,7 +216,7 @@ void CDrawUtilities::OnDeviceCreate()
216216
// initialize identity box
217217
Fbox bb;
218218
bb.set(-0.505f,-0.505f,-0.505f, 0.505f,0.505f,0.505f);
219-
for (i=0; i<8; i++){
219+
for (int i=0; i<8; i++){
220220
Fvector S;
221221
Fvector p;
222222
bb.getpoint(i,p);

src/Layers/xrRender/DetailManager_VS.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ void CDetailManager::hw_Load_Geom()
8484
#else // USE_DX10
8585
R_CHK (hw_VB->Lock(0,0,(void**)&pV,0));
8686
#endif // USE_DX10
87-
for (o=0; o<objects.size(); o++)
87+
for (u32 o=0; o<objects.size(); o++)
8888
{
8989
const CDetail& D = *objects[o];
9090
for (u32 batch=0; batch<hw_BatchSize; batch++)
@@ -126,7 +126,7 @@ void CDetailManager::hw_Load_Geom()
126126
#else // USE_DX10
127127
R_CHK (hw_IB->Lock(0,0,(void**)(&pI),0));
128128
#endif // USE_DX10
129-
for (o=0; o<objects.size(); o++)
129+
for (u32 o=0; o<objects.size(); o++)
130130
{
131131
const CDetail& D = *objects[o];
132132
u16 offset = 0;

src/Layers/xrRender/SkeletonAnimated.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -655,7 +655,7 @@ void CKinematicsAnimated::IBlend_Startup ()
655655
#endif
656656
}
657657
// cycles+fx clear
658-
for (i=0; i<MAX_PARTS; i++)
658+
for (u32 i=0; i<MAX_PARTS; i++)
659659
blend_cycles[i].clear();
660660
blend_fx.clear ();
661661
ChannelFactorsStartup();

src/Layers/xrRender/SkeletonCustom.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -607,7 +607,7 @@ void CKinematics::AddWallmark(const Fmatrix* parent_xform, const Fvector3& start
607607
test_sphere.set (cp,size);
608608
U16Vec test_bones;
609609
test_bones.reserve (LL_BoneCount());
610-
for (k=0; k<LL_BoneCount(); k++){
610+
for (u16 k=0; k<LL_BoneCount(); k++){
611611
CBoneData& BD = LL_GetData(k);
612612
if (LL_GetBoneVisible(k)&&!BD.shape.flags.is(SBoneShape::sfNoPickable)){
613613
Fobb& obb = cache_obb[k];

src/Layers/xrRender/WallmarksEngine.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ void CWallmarksEngine::RecurseTri(u32 t, Fmatrix &mView, CWallmarksEngine::stati
152152
}
153153

154154
// recurse
155-
for (i=0; i<3; i++)
155+
for (u32 i=0; i<3; i++)
156156
{
157157
u32 adj = sml_adjacency[3*t+i];
158158
if (0xffffffff==adj) continue;

src/Layers/xrRender/dxObjectSpaceRender.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ void dxObjectSpaceRender::dbgRender()
4141
}
4242
q_debug.boxes.clear();
4343

44-
for (i=0; i<dbg_S.size(); i++)
44+
for (u32 i=0; i<dbg_S.size(); i++)
4545
{
4646
std::pair<Fsphere,u32>& P = dbg_S[i];
4747
Fsphere& S = P.first;

src/Layers/xrRender/dxStatGraphRender.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -172,7 +172,7 @@ void dxStatGraphRender::RenderBack(CStatGraph &owner)
172172
pv->set (owner.rb.x,int(base_y+g_y*owner.grid_step.y*elem_factor),owner.grid_color); pv++;
173173
};
174174

175-
for (g_y=1; g_y<=Num_H_LinesUp; g_y++)
175+
for (int g_y=1; g_y<=Num_H_LinesUp; g_y++)
176176
{
177177
pv->set (owner.lt.x,int(base_y-g_y*owner.grid_step.y*elem_factor),owner.grid_color); pv++;
178178
pv->set (owner.rb.x,int(base_y-g_y*owner.grid_step.y*elem_factor),owner.grid_color); pv++;

src/Layers/xrRenderPC_GL/gl_loader.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,7 @@ void CRender::LoadSectors(IReader* fs)
317317
{
318318
CDB::Collector CL;
319319
fs->find_chunk (fsL_PORTALS);
320-
for (i=0; i<count; i++)
320+
for (u32 i=0; i<count; i++)
321321
{
322322
b_portal P;
323323
fs->r (&P,sizeof(P));

src/Layers/xrRenderPC_GL/gl_rendertarget.cpp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -766,10 +766,12 @@ CRenderTarget::CRenderTarget ()
766766
}
767767
}
768768
}
769-
770-
for (int it3=0; it3<TEX_jitter_count-1; it3++) {
769+
int it3 = 0;
770+
while (it3<TEX_jitter_count-1)
771+
{
771772
CHK_GL (glBindTexture(GL_TEXTURE_2D, t_noise_surf[it3]));
772773
CHK_GL (glTexSubImage2D(GL_TEXTURE_2D, 0, 0, 0, TEX_jitter, TEX_jitter, GL_RGBA, GL_UNSIGNED_BYTE, tempData[it3]));
774+
it3++;
773775
}
774776

775777
float tempDataHBAO[TEX_jitter*TEX_jitter * 4];

src/Layers/xrRenderPC_GL/gl_rendertarget_phase_bloom.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,8 @@ void CalcGauss_k7(
4040
// calculate
4141
float mag = 0;
4242
for (int i=-7; i<=0; i++) W[-i] = expf (-float(i*i)/(2*r*r)); // weight
43-
for (i=0; i<8; i++) mag += i?2*W[i]:W[i]; // symmetrical weight
44-
for (i=0; i<8; i++) W[i] = s_out*W[i]/mag;
43+
for (int i=0; i<8; i++) mag += i?2*W[i]:W[i]; // symmetrical weight
44+
for (int i=0; i<8; i++) W[i] = s_out*W[i]/mag;
4545

4646
// W[0]=0, W[7]=-7
4747
w0.set (W[1],W[2],W[3],W[4]); // -1, -2, -3, -4

0 commit comments

Comments
 (0)