Fix various minor issues

Author: Zegeri

src/Common/PlatformLinux.inl

@@ -150,7 +150,7 @@ typedef unsigned char* LPBYTE;
 typedef unsigned int UINT;
 typedef int INT;
 typedef unsigned long ULONG;
-typedef unsigned long& ULONG_PTR;
+typedef unsigned long* ULONG_PTR;
 typedef long long int LARGE_INTEGER;
 typedef unsigned long long int ULARGE_INTEGER;
 
@@ -208,7 +208,7 @@ typedef unsigned int UINT_PTR;
 typedef long LONG_PTR;
 #endif // XR_X64
 
-typedef int HANDLE;
+typedef void* HANDLE;
 typedef void* HMODULE;
 typedef void* PVOID;
 typedef void* LPVOID;

src/xrGame/MainMenu.cpp

@@ -761,7 +761,7 @@ bool CMainMenu::IsCDKeyIsValid()
     for (int i = 0; i < 4; i++)
     {
         GetGameID(&GameID, i);
-        if (VerifyClientCheck(CDKey, unsigned short(GameID)) == 1)
+        if (VerifyClientCheck(CDKey, (unsigned short)(GameID)) == 1)
             return true;
     };
     return false;

src/xrGame/PHSkeleton.cpp

@@ -388,7 +388,7 @@ void CPHSkeleton::RecursiveBonesCheck(u16 id)
     Flags64 mask;
     mask.assign(K->LL_GetBonesVisible());
     ///////////////////////////////////////////
-    if (mask.is(1ui64 << (u64)id) && !(BD.shape.flags.is(SBoneShape::sfRemoveAfterBreak)))
+    if (mask.is(u64(1) << (u64)id) && !(BD.shape.flags.is(SBoneShape::sfRemoveAfterBreak)))
     {
         removable = false;
         return;

src/xrGame/ai/monsters/state.h

@@ -8,6 +8,8 @@
 #include "debug_text_tree.h"
 #endif
 
+inline TTime current_time() { return Device.dwTimeGlobal; }
+
 template <typename _Object>
 class CState
 {

src/xrGame/ai/monsters/state_inline.h

@@ -205,8 +205,8 @@ EMonsterState CStateAbstract::get_state_type()
 TEMPLATE_SPECIALIZATION
 void CStateAbstract::remove_links(IGameObject* object)
 {
-    SubStates::iterator i = substates.begin();
-    SubStates::iterator e = substates.end();
+    auto i = substates.begin();
+    auto e = substates.end();
     for (; i != e; ++i)
         (*i).second->remove_links(object);
 }

src/xrGame/ai/monsters/states/monster_state_attack_on_run.h

@@ -5,7 +5,6 @@
 
 #include "ai/weighted_random.h"
 
-inline TTime current_time() { return Device.dwTimeGlobal; }
 template <typename _Object>
 class CStateMonsterAttackOnRun : public CState<_Object>
 {

src/xrGame/ai/monsters/states/monster_state_squad_rest_follow_inline.h

@@ -2,6 +2,7 @@
 
 #include "state_custom_action.h"
 #include "state_move_to_point.h"
+#include "ai_monster_squad.h"
 
 #define TEMPLATE_SPECIALIZATION \
     template <typename _Object\

src/xrGame/attachable_item.cpp

@@ -125,7 +125,7 @@ void CAttachableItem::afterDetach()
     object().processing_deactivate();
 }
 
-virtual bool CAttachableItem::use_parent_ai_locations() const
+bool CAttachableItem::use_parent_ai_locations() const
 {
     return !enabled();
 }

src/xrGame/entity_alive.cpp

@@ -690,7 +690,7 @@ ICollisionHitCallback* CEntityAlive::get_collision_hit_callback()
     if (cs)
         return cs->get_collision_hit_callback();
     else
-        return false;
+        return nullptr;
 }
 
 void CEntityAlive::set_collision_hit_callback(ICollisionHitCallback* cc)

src/xrGame/game_sv_mp.cpp

@@ -229,6 +229,7 @@ struct real_sender
         P = Packet;
         flags_to_send = flags;
     }
+
     void operator()(IClient* client)
     {
         xrClientData* tmp_client = static_cast<xrClientData*>(client);