Fix serious issues with XRay::Module

1. Fix handle fills with trash on construction
2. Add new param dontUnload, which used for renderers to prevent RTTI
invalidation
(fe7bc5f)

Author: Xottab-DUTY

src/xrCore/ModuleLookup.cpp

@@ -4,32 +4,34 @@
 
 namespace XRay
 {
-Module::Module() : handle(nullptr) {}
+Module::Module(const bool dontUnload) : handle(nullptr), dontUnload(dontUnload) {}
 
-Module::Module(pcstr moduleName, bool log /*= true*/)
+Module::Module(pcstr moduleName, bool dontUnload /*= false*/) : handle(nullptr)
 {
-    open(moduleName, log);
+    open(moduleName);
 }
 
 Module::~Module()
 {
     close();
 }
 
-void* Module::open(pcstr moduleName, bool log /*= true*/)
+void* Module::open(pcstr moduleName)
 {
     if (exist())
         close();
-
-    if (log)
-        Log("Loading DLL:", moduleName);
+    
+    Log("Loading DLL:", moduleName);
 
     handle = ::LoadLibrary(moduleName);
     return handle;
 }
 
 void Module::close()
 {
+    if (dontUnload)
+        return;
+
     FreeLibrary(static_cast<HMODULE>(handle));
     handle = nullptr;
 }

src/xrCore/ModuleLookup.hpp

@@ -5,13 +5,14 @@ namespace XRay
 class XRCORE_API Module
 {
     void* handle;
+    bool dontUnload;
 
 public:
-    Module();
-    Module(pcstr moduleName, bool log = true);
+    Module(const bool dontUnload = false);
+    Module(pcstr moduleName, bool dontUnload = false);
     ~Module();
 
-    void* open(pcstr moduleName, bool log = true);
+    void* open(pcstr moduleName);
     void close();
 
     bool exist() const;

src/xrEngine/EngineAPI.cpp

@@ -199,7 +199,7 @@ void CEngineAPI::CreateRendererList()
     bool bSupports_r3 = false;
     bool bSupports_r4 = false;
 
-    hRender = std::make_unique<XRay::Module>();
+    hRender = std::make_unique<XRay::Module>(true);
 
     if (strstr(Core.Params, "-perfhud_hack"))
     {