Skip to content

Commit aad51bf

Browse files
committed
refactor: remove most -Wconversion-null warnings
1 parent cdfd42f commit aad51bf

21 files changed

+50
-50
lines changed

src/Layers/xrRender/ShaderResourceTraits.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -354,7 +354,7 @@ inline T* CResourceManager::CreateShader(const char* name, const char* filename
354354
sh_map.insert(std::make_pair(sh->set_name(name), sh));
355355
if (0 == xr_stricmp(name, "null"))
356356
{
357-
sh->sh = NULL;
357+
sh->sh = 0;
358358
return sh;
359359
}
360360

@@ -408,7 +408,7 @@ inline T* CResourceManager::CreateShader(const char* name, const char* filename
408408
ShaderTypeTraits<T>::GetCompilationTarget(c_target, c_entry, data);
409409

410410
#ifdef USE_OGL
411-
DWORD flags = NULL;
411+
DWORD flags = 0;
412412
#elif defined(USE_DX10) || defined(USE_DX11)
413413
DWORD flags = D3D10_SHADER_PACK_MATRIX_ROW_MAJOR;
414414
#else

src/Layers/xrRenderGL/glSH_Texture.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ void resptrcode_texture::create(LPCSTR _name)
2727
//////////////////////////////////////////////////////////////////////
2828
CTexture::CTexture()
2929
{
30-
pSurface = NULL;
31-
pBuffer = NULL;
30+
pSurface = 0;
31+
pBuffer = 0;
3232
pAVI = nullptr;
3333
pTheora = nullptr;
3434
desc = GL_TEXTURE_2D;

src/Layers/xrRenderPC_GL/glResourceManager_Resources.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -212,7 +212,7 @@ SVS* CResourceManager::_CreateVS(LPCSTR _name)
212212
// Select target
213213
_vs->sh = glCreateShader(GL_VERTEX_SHADER);
214214
void* _result = &_vs->sh;
215-
HRESULT const _hr = GEnv.Render->shader_compile(name, file, nullptr, nullptr, NULL, _result);
215+
HRESULT const _hr = GEnv.Render->shader_compile(name, file, nullptr, nullptr, 0, _result);
216216

217217
FS.r_close(file);
218218

@@ -292,7 +292,7 @@ SPS* CResourceManager::_CreatePS(LPCSTR _name)
292292
// Select target
293293
_ps->sh = glCreateShader(GL_FRAGMENT_SHADER);
294294
void* _result = &_ps->sh;
295-
HRESULT const _hr = GEnv.Render->shader_compile(name, file, nullptr, nullptr, NULL, _result);
295+
HRESULT const _hr = GEnv.Render->shader_compile(name, file, nullptr, nullptr, 0, _result);
296296

297297
FS.r_close(file);
298298

@@ -362,7 +362,7 @@ SGS* CResourceManager::_CreateGS(LPCSTR name)
362362
_gs->sh = glCreateShader(GL_GEOMETRY_SHADER);
363363
void* _result = &_gs->sh;
364364
HRESULT const _hr = GEnv.Render->shader_compile(name, file, nullptr,
365-
nullptr, NULL, _result);
365+
nullptr, 0, _result);
366366

367367
VERIFY(SUCCEEDED(_hr));
368368

src/Layers/xrRenderPC_GL/gl_R_render.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -177,7 +177,7 @@ void CRender::render_menu()
177177
}
178178

179179
// Actual Display
180-
Target->u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT,NULL,NULL, HW.pBaseZB);
180+
Target->u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT, 0, 0, HW.pBaseZB);
181181
RCache.set_Shader(Target->s_menu);
182182
RCache.set_Geometry(Target->g_menu);
183183

@@ -228,7 +228,7 @@ void CRender::Render()
228228
if (!(g_pGameLevel && g_hud)
229229
|| bMenu)
230230
{
231-
Target->u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT,NULL,NULL, HW.pBaseZB);
231+
Target->u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT, 0, 0, HW.pBaseZB);
232232
return;
233233
}
234234

src/Layers/xrRenderPC_GL/gl_rendertarget.cpp

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -599,7 +599,7 @@ CRenderTarget::CRenderTarget()
599599
FLOAT ColorRGBA[4] = {127.0f / 255.0f, 127.0f / 255.0f, 127.0f / 255.0f, 127.0f / 255.0f};
600600
HW.pDevice->ClearRenderTargetView(rt_LUM_pool[it]->pRT, ColorRGBA);
601601
}
602-
u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT,NULL,NULL, HW.pBaseZB);
602+
u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT, 0, 0, HW.pBaseZB);
603603
}
604604

605605
// HBAO
@@ -911,11 +911,11 @@ CRenderTarget::~CRenderTarget()
911911
glDeleteTextures(1, &t_ss_async);
912912

913913
// Textures
914-
t_material->surface_set(GL_TEXTURE_2D, NULL);
914+
t_material->surface_set(GL_TEXTURE_2D, 0);
915915
glDeleteTextures(1, &t_material_surf);
916916

917-
t_LUM_src->surface_set(GL_TEXTURE_2D, NULL);
918-
t_LUM_dest->surface_set(GL_TEXTURE_2D, NULL);
917+
t_LUM_src->surface_set(GL_TEXTURE_2D, 0);
918+
t_LUM_dest->surface_set(GL_TEXTURE_2D, 0);
919919

920920
#ifdef DEBUG
921921
GLuint pSurf = 0;
@@ -926,8 +926,8 @@ CRenderTarget::~CRenderTarget()
926926
pSurf = t_envmap_1->surface_get();
927927
glDeleteTextures(1, &pSurf);
928928
#endif // DEBUG
929-
t_envmap_0->surface_set(GL_TEXTURE_CUBE_MAP, NULL);
930-
t_envmap_1->surface_set(GL_TEXTURE_CUBE_MAP, NULL);
929+
t_envmap_0->surface_set(GL_TEXTURE_CUBE_MAP, 0);
930+
t_envmap_1->surface_set(GL_TEXTURE_CUBE_MAP, 0);
931931
t_envmap_0.destroy();
932932
t_envmap_1.destroy();
933933

@@ -937,11 +937,11 @@ CRenderTarget::~CRenderTarget()
937937
// Jitter
938938
for (int it = 0; it < TEX_jitter_count; it++)
939939
{
940-
t_noise [it]->surface_set(GL_TEXTURE_2D, NULL);
940+
t_noise [it]->surface_set(GL_TEXTURE_2D, 0);
941941
}
942942
glDeleteTextures(TEX_jitter_count, t_noise_surf);
943943

944-
t_noise_mipped->surface_set(GL_TEXTURE_2D, NULL);
944+
t_noise_mipped->surface_set(GL_TEXTURE_2D, 0);
945945
glDeleteTextures(1, &t_noise_surf_mipped);
946946

947947
//

src/Layers/xrRenderPC_GL/gl_rendertarget_create_minmaxSM.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ void CRenderTarget::create_minmax_SM()
1818
pv++;
1919
RCache.Vertex.Unlock(4, g_combine_2UV->vb_stride);
2020
//u_setrt (rt_smap_depth_minmax_temp,NULL,NULL,NULL);
21-
u_setrt(rt_smap_depth_minmax,NULL,NULL,NULL);
21+
u_setrt(rt_smap_depth_minmax, 0, 0, 0);
2222
RCache.set_Element(s_create_minmax_sm->E[0]);
2323
RCache.set_Geometry(g_combine_2UV);
2424
RCache.set_Stencil(FALSE, D3DCMP_ALWAYS, 0x80, 0xFF, 0x80, D3DSTENCILOP_KEEP, D3DSTENCILOP_REPLACE,

src/Layers/xrRenderPC_GL/gl_rendertarget_phase_PP.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ struct TL_2c3uv
115115
void CRenderTarget::phase_pp()
116116
{
117117
// combination/postprocess
118-
u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT,NULL,NULL, HW.pBaseZB);
118+
u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT, 0, 0, HW.pBaseZB);
119119
// Element 0 for for normal post-process
120120
// Element 4 for color map post-process
121121
bool bCMap = u_need_CM();

src/Layers/xrRenderPC_GL/gl_rendertarget_phase_bloom.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ void CRenderTarget::phase_bloom()
7171
u32 Offset;
7272

7373
// Targets
74-
u_setrt(rt_Bloom_1,NULL,NULL,NULL); // No need for ZBuffer at all
74+
u_setrt(rt_Bloom_1, 0, 0, 0); // No need for ZBuffer at all
7575
//RImplementation.rmNormal();
7676

7777
// Clear - don't clear - it's stupid here :)
@@ -187,12 +187,12 @@ void CRenderTarget::phase_bloom()
187187
RCache.set_Geometry(g_bloom_build);
188188

189189
// P0
190-
u_setrt(rt_Bloom_2,NULL,NULL,NULL); // No need for ZBuffer at all
190+
u_setrt(rt_Bloom_2, 0, 0, 0); // No need for ZBuffer at all
191191
RCache.set_Element(s_bloom->E[3]);
192192
RCache.Render(D3DPT_TRIANGLELIST, Offset, 0, 4, 0, 2);
193193

194194
// P1
195-
u_setrt(rt_Bloom_1,NULL,NULL,NULL); // No need for ZBuffer at all
195+
u_setrt(rt_Bloom_1, 0, 0, 0); // No need for ZBuffer at all
196196
RCache.set_Element(s_bloom->E[4]);
197197
RCache.Render(D3DPT_TRIANGLELIST, Offset, 0, 4, 0, 2);
198198
}
@@ -271,7 +271,7 @@ void CRenderTarget::phase_bloom()
271271
Fvector4 w0, w1;
272272
float kernel = ps_r2_ls_bloom_kernel_g;
273273
CalcGauss_wave(w0, w1, kernel, kernel / 3.f, ps_r2_ls_bloom_kernel_scale);
274-
u_setrt(rt_Bloom_2,NULL,NULL,NULL); // No need for ZBuffer at all
274+
u_setrt(rt_Bloom_2, 0, 0, 0); // No need for ZBuffer at all
275275
RCache.set_Element(s_bloom->E[1]);
276276
RCache.set_ca("weight", 0, w0);
277277
RCache.set_ca("weight", 1, w1);
@@ -351,7 +351,7 @@ void CRenderTarget::phase_bloom()
351351
Fvector4 w0, w1;
352352
float kernel = ps_r2_ls_bloom_kernel_g * float(Device.dwHeight) / float(Device.dwWidth);
353353
CalcGauss_wave(w0, w1, kernel, kernel / 3.f, ps_r2_ls_bloom_kernel_scale);
354-
u_setrt(rt_Bloom_1,NULL,NULL,NULL); // No need for ZBuffer at all
354+
u_setrt(rt_Bloom_1, 0, 0, 0); // No need for ZBuffer at all
355355
RCache.set_Element(s_bloom->E[2]);
356356
RCache.set_ca("weight", 0, w0);
357357
RCache.set_ca("weight", 1, w1);

src/Layers/xrRenderPC_GL/gl_rendertarget_phase_combine.cpp

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -355,14 +355,14 @@ void CRenderTarget::phase_combine()
355355
if (RImplementation.o.dx10_msaa)
356356
{
357357
if (PP_Complex) u_setrt(rt_Generic, 0, 0, HW.pBaseZB); // LDR RT
358-
else u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT,NULL,NULL, HW.pBaseZB);
358+
else u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT, 0, 0, HW.pBaseZB);
359359
}
360360
else
361361
{
362362
if (PP_Complex) u_setrt(rt_Color, 0, 0, HW.pBaseZB); // LDR RT
363-
else u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT,NULL,NULL, HW.pBaseZB);
363+
else u_setrt(Device.dwWidth, Device.dwHeight, HW.pBaseRT, 0, 0, HW.pBaseZB);
364364
}
365-
//. u_setrt ( Device.dwWidth,Device.dwHeight,HW.pBaseRT,NULL,NULL,HW.pBaseZB);
365+
//. u_setrt ( Device.dwWidth,Device.dwHeight,HW.pBaseRT, 0, 0,HW.pBaseZB);
366366
RCache.set_CullMode(CULL_NONE);
367367
RCache.set_Stencil(FALSE);
368368

@@ -483,8 +483,8 @@ void CRenderTarget::phase_combine()
483483
//*** exposure-pipeline-clear
484484
{
485485
std::swap(rt_LUM_pool[gpu_id * 2 + 0], rt_LUM_pool[gpu_id * 2 + 1]);
486-
t_LUM_src->surface_set(GL_TEXTURE_2D, NULL);
487-
t_LUM_dest->surface_set(GL_TEXTURE_2D, NULL);
486+
t_LUM_src->surface_set(GL_TEXTURE_2D, 0);
487+
t_LUM_dest->surface_set(GL_TEXTURE_2D, 0);
488488
}
489489

490490
#ifdef DEBUG
@@ -595,8 +595,8 @@ void CRenderTarget::phase_combine()
595595
void CRenderTarget::phase_wallmarks()
596596
{
597597
// Targets
598-
RCache.set_RT(NULL, 2);
599-
RCache.set_RT(NULL, 1);
598+
RCache.set_RT(0, 2);
599+
RCache.set_RT(0, 1);
600600
if (!RImplementation.o.dx10_msaa)
601601
u_setrt(rt_Color,NULL,NULL, HW.pBaseZB);
602602
else

src/Layers/xrRenderPC_GL/gl_rendertarget_phase_luminance.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ void CRenderTarget::phase_luminance()
3131
//CHK_DX (HW.pDevice->SetRenderState (D3DRS_ZENABLE,FALSE));
3232

3333
// 000: Perform LUM-SAT, pass 0, 256x256 => 64x64
34-
u_setrt(rt_LUM_64,NULL,NULL,NULL);
34+
u_setrt(rt_LUM_64, 0, 0, 0);
3535
//RImplementation.rmNormal();
3636
{
3737
float ts = 64;
@@ -81,7 +81,7 @@ void CRenderTarget::phase_luminance()
8181
}
8282

8383
// 111: Perform LUM-SAT, pass 1, 64x64 => 8x8
84-
u_setrt(rt_LUM_8,NULL,NULL,NULL);
84+
u_setrt(rt_LUM_8, 0, 0, 0);
8585
//RImplementation.rmNormal();
8686
{
8787
// Build filter-kernel
@@ -118,7 +118,7 @@ void CRenderTarget::phase_luminance()
118118

119119
// 222: Perform LUM-SAT, pass 2, 8x8 => 1x1
120120
u32 gpu_id = Device.dwFrame % HW.Caps.iGPUNum;
121-
u_setrt(rt_LUM_pool[gpu_id * 2 + 1],NULL,NULL,NULL);
121+
u_setrt(rt_LUM_pool[gpu_id * 2 + 1], 0, 0, 0);
122122
//RImplementation.rmNormal();
123123
{
124124
// Build filter-kernel

0 commit comments

Comments
 (0)