Fix some anomalies found with PVS-Studio (#140)

Author: Xottab-DUTY

src/Layers/xrRenderPC_R1/FStaticRender_RenderTarget.cpp

@@ -26,7 +26,7 @@ CRenderTarget::CRenderTarget()
     param_color_map_influence = 0.0f;
     param_color_map_interpolate = 0.0f;
 
-    im_noise_time = 1 / 100;
+    im_noise_time = 1 / 100.0f;
     im_noise_shift_w = 0;
     im_noise_shift_h = 0;
 

src/Layers/xrRenderPC_R2/r2_rendertarget.cpp

@@ -195,7 +195,7 @@ CRenderTarget::CRenderTarget()
     param_noise_fps = 25.f;
     param_noise_scale = 1.f;
 
-    im_noise_time = 1 / 100;
+    im_noise_time = 1 / 100.0f;
     im_noise_shift_w = 0;
     im_noise_shift_h = 0;
 

src/Layers/xrRenderPC_R3/r3_rendertarget.cpp

@@ -291,7 +291,7 @@ CRenderTarget::CRenderTarget()
     param_noise_fps = 25.f;
     param_noise_scale = 1.f;
 
-    im_noise_time = 1 / 100;
+    im_noise_time = 1 / 100.0f;
     im_noise_shift_w = 0;
     im_noise_shift_h = 0;
 

src/Layers/xrRenderPC_R4/r4_rendertarget.cpp

@@ -293,7 +293,7 @@ CRenderTarget::CRenderTarget()
     param_noise_fps = 25.f;
     param_noise_scale = 1.f;
 
-    im_noise_time = 1 / 100;
+    im_noise_time = 1 / 100.0f;
     im_noise_shift_w = 0;
     im_noise_shift_h = 0;
 

src/utils/LWO/lwio.c

@@ -335,7 +335,7 @@ int sgetI1(unsigned char** bp)
     if (i > 127)
         i -= 256;
     flen += 1;
-    *bp++;
+    (*bp)++;
     return i;
 }
 
@@ -373,7 +373,7 @@ unsigned char sgetU1(unsigned char** bp)
         return 0;
     c = **bp;
     flen += 1;
-    *bp++;
+    (*bp)++;
     return c;
 }
 

src/utils/LWO/lwob.c

@@ -79,7 +79,7 @@ static int add_clip(char* s, lwClip** clist, int* nclips)
         clip->source.still.name = s;
     }
 
-    *nclips++;
+    (*nclips)++;
     clip->index = *nclips;
 
     lwListAdd(clist, clip);

src/utils/xrDXT/NVI_Image.cpp

@@ -151,10 +151,10 @@ void NVI_Image::ABGR8_To_ARGB8()
     {
         DWORD col;
         GetPixel_ARGB8(&col, i);
-        DWORD a = (col >> 24) && 0x000000FF;
-        DWORD b = (col >> 16) && 0x000000FF;
-        DWORD g = (col >> 8) && 0x000000FF;
-        DWORD r = (col >> 0) && 0x000000FF;
+        DWORD a = (col >> 24) & 0x000000FF;
+        DWORD b = (col >> 16) & 0x000000FF;
+        DWORD g = (col >> 8) & 0x000000FF;
+        DWORD r = (col >> 0) & 0x000000FF;
         col = (a << 24) | (r << 16) | (g << 8) | b;
         SetPixel_ARGB8(i, col);
     }

src/utils/xrDXT/dds/tPixel.h

@@ -952,7 +952,7 @@ class RGBAMipMappedCubeMap
     const RGBAMipMappedImage& operator[](size_t i) const { return cubeFaces[i]; }
     size_t numMIPMaps() const { return cubeFaces[0].numMIPMaps(); }
     size_t height() const { return cubeFaces[0].height(); }
-    size_t width() const { return cubeFaces[0].height(); }
+    size_t width() const { return cubeFaces[0].width(); }
     void clear()
     {
         for (size_t f = 0; f < 6; f++)
@@ -1140,7 +1140,7 @@ class fpMipMappedCubeMap
     const fpMipMappedImage& operator[](size_t i) const { return cubeFaces[i]; }
     size_t numMIPMaps() const { return cubeFaces[0].numMIPMaps(); }
     size_t height() const { return cubeFaces[0].height(); }
-    size_t width() const { return cubeFaces[0].height(); }
+    size_t width() const { return cubeFaces[0].width(); }
     void clear()
     {
         for (size_t f = 0; f < 6; f++)

src/utils/xrQSlim/src/MxQMetric.cpp

@@ -81,7 +81,7 @@ MxMatrix& MxQuadric::homogeneous(MxMatrix& H) const
     unsigned int i, j;
 
     for (i = 0; i < A.dim(); i++)
-        for (j = 0; j < A.dim(); i++)
+        for (j = 0; j < A.dim(); j++)
             H(i, j) = A(i, j);
 
     for (i = 0; i < b.dim(); i++)

src/xrCore/_matrix33.h

@@ -377,6 +377,7 @@ struct _matrix33
         R.x = s1 * (m[0][0] * V1.x + m[1][0] * V1.y + m[2][0] * V1.z);
         R.y = s1 * (m[0][1] * V1.x + m[1][1] * V1.y + m[2][1] * V1.z);
         R.z = s1 * (m[0][2] * V1.x + m[1][2] * V1.y + m[2][2] * V1.z);
+        return *this;
     }
     IC SelfRef MxV(Tvector& R, const Tvector& V1) const
     {