Skip to content

Fix rev tools light dark mode #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: OpenXTalk-develop-1.963.1
Choose a base branch
from

Conversation

mwieder
Copy link

@mwieder mwieder commented Jun 16, 2024

Here's a possibility for fixing the multiple-stacks error you're getting from loading PowerTools.
I moved the background/foreground colorizing into your oxttools stack and dispatch the call from the home stack.

Copy link
Member

@PaulMcClernan PaulMcClernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is the Tools stack I had always intended to swap out with something (hopefully) much better (see 'Tools redo' thread on the forums for example). I'd rather not put handlers for dealing with dark mode into IDE stacks, rather I think it should be handled in a separate library, one that we can then adjust for peculiarities in certain Linux themes or that can use a JS handler when run in a web browser environment to figure out if the user is in a dark theme / has light foreColor/dark backColor. We want a cross-platform 'darkMode'. Since this may involve evaluation of RGB triplets (because maybe the user is in a 'orange text on blue backColor' mode?), I think this should be put into an 'OXT color' library that covers the functionality of Quatram Color Library, tinyColor library, along with some handlers that I've created to RGB stuff and Read GIMP Color palettes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants