Ignore most significant bit kWh readings#2598
Open
markruys wants to merge 2 commits intoOpenZWave:masterfrom
Open
Ignore most significant bit kWh readings#2598markruys wants to merge 2 commits intoOpenZWave:masterfrom
markruys wants to merge 2 commits intoOpenZWave:masterfrom
Conversation
38ce4e9 to
8a19338
Compare
|
Any chance that this change is merged to the master and will be included in then next release or beta (V1.7)? As all new models of this wall plug (Neo CoolCam NAS-WR01ZE) seem to have this nasty behavior, more and more people will benefit from this change . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Neo Coolcam NAS-WR01ZE randomly reports kWh value with the most significant bit set. This results in erroneous negative readings:
OZW expects a 32-bit signed int, hence the negative readings. According to the docs of this device, the maximum report value is 21474836.47 kWh, which is
0x7FFFFFFF. This PR resets resets the most significant bit to 0. This results in:I expect this PR addresses issues #1724, #2062, and #2333 wrt NAS-WR01ZE.