Clarify RPC error handling design in simulation.ts

[Copilot]

Addressed review feedback on PR #51 regarding error message handling in src/plugin/simulation.ts. The reviewer questioned why RPC error details were removed from the client response.

Context

The current implementation intentionally:

• Logs full RPC error details (code, message, description/data) to console.error for server-side debugging
• Returns only a generic "RPC provider error" message to clients to avoid exposing internal implementation details

if (rpcResponse.error) {
  const { code, message, description, data } = rpcResponse.error as any;
  console.error(`[channels] RPC error: code=${code}, message=${message}, detail=${description || data}`);
  throw pluginError('Simulation RPC failed', {
    code: 'SIMULATION_RPC_FAILURE',
    status: HTTP_STATUS.BAD_GATEWAY,
    details: { message: 'RPC provider error' },  // Generic for security
  });
}

Resolution

Confirmed with @tirumerla that this is the intended design. No code changes required.

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}