feat: co-locate heading and some type styles in Reboot to avoid some extend…#3326
Draft
MaxLardenois wants to merge 4 commits intoouds/mainfrom
Draft
feat: co-locate heading and some type styles in Reboot to avoid some extend…#3326MaxLardenois wants to merge 4 commits intoouds/mainfrom
MaxLardenois wants to merge 4 commits intoouds/mainfrom
Conversation
* Don't disallow calc() * Remove disables that aren't needed * Remove custom subtract and add functions * Remove more disables * keep it here
…s and extra dependencies once we migrate to Sass modules (#41697)
github-project-automation
bot
moved this to In Progress / Draft
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
Base automatically changed from
ouds/main-ml-remove-add-subtract
to
ouds/main
January 27, 2026 14:32
boosted-bot
moved this from In Progress / Draft
to Need Dev Review
in 🟣 [Orange-Boosted-Bootstrap] PRs Board
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Member
louismaximepiton
left a comment
louismaximepiton
left a comment
There was a problem hiding this comment.
The changes look fine to me, but I have three questions in mind:
- Should we change the documentation to reflect these changes ?
- The remaining of the type.scss file looks weird to me, since there is .lead but not .small for example. There are .display-* but no .h*
- reboot file shouldn't contain any class at all.
Is there a better solution easing the transition to Scss modules and filling all the requirements above ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change
Description
co-locate heading and some type styles in Reboot to avoid some extends and extra dependencies once we migrate to Sass modules
Checklists
Checklist (for Core Team only)
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews