Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
MaxLardenois
left a comment
There was a problem hiding this comment.
I have questions about the roles on footer and banner
| </svg> | ||
|
|
||
| <header class="sticky-top" data-bs-theme="dark"> | ||
| <header class="sticky-top" data-bs-theme="dark" role="banner"> |
There was a problem hiding this comment.
<header> element has a banner role by default (except if it is inside another semantic element, but it's not the case here)
There was a problem hiding this comment.
It's mainly in prevention, for people using old ATs/browsers couples and don't support this by default (which happens a lot on the few figures I have, but they may be wrong by the time (https://access42.net/uploads/2017/06/presentation_etude-le-bv_05122017v2.pdf) (2020 figures haven't been published yet and I don't know why 🤷)).
It's only proposals, but we can remove the PRs since these changes should be only for the old couples.
There was a problem hiding this comment.
The document is very old, more than 8 years old, not sure if it is still relevant. I would probably remove it, if it is already the built-in role.
Related issues
NA
Description
Add some unique roles that might be an issue in the future to better convey information to ATs.
Checklists
Progression (for Core Team only)
ouds/mainfollowing conventional commitLive previews