Skip to content

fix(a11y): better a11y on doc#3332

Merged
vprothais merged 5 commits intoouds/mainfrom
ouds/main-lmp-fix-a11y-zones
Feb 16, 2026
Merged

fix(a11y): better a11y on doc#3332
vprothais merged 5 commits intoouds/mainfrom
ouds/main-lmp-fix-a11y-zones

Conversation

@louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Feb 2, 2026

Related issues

NA

Description

Add some unique roles that might be an issue in the future to better convey information to ATs.

Checklists

Progression (for Core Team only)

Live previews

@netlify
Copy link

netlify bot commented Feb 2, 2026

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 821e4ab
🔍 Latest deploy log https://app.netlify.com/projects/boosted/deploys/6993310f43915e0008bd4758
😎 Deploy Preview https://deploy-preview-3332--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Collaborator

@MaxLardenois MaxLardenois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have questions about the roles on footer and banner

</svg>

<header class="sticky-top" data-bs-theme="dark">
<header class="sticky-top" data-bs-theme="dark" role="banner">
Copy link
Collaborator

@MaxLardenois MaxLardenois Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<header> element has a banner role by default (except if it is inside another semantic element, but it's not the case here)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's mainly in prevention, for people using old ATs/browsers couples and don't support this by default (which happens a lot on the few figures I have, but they may be wrong by the time (https://access42.net/uploads/2017/06/presentation_etude-le-bv_05122017v2.pdf) (2020 figures haven't been published yet and I don't know why 🤷)).

It's only proposals, but we can remove the PRs since these changes should be only for the old couples.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The document is very old, more than 8 years old, not sure if it is still relevant. I would probably remove it, if it is already the built-in role.

@boosted-bot boosted-bot moved this from Need Dev Review to Need Lead Dev Review in 🟣 [Orange-Boosted-Bootstrap] PRs Board Feb 16, 2026
@vprothais vprothais merged commit d873a8f into ouds/main Feb 16, 2026
13 checks passed
@vprothais vprothais deleted the ouds/main-lmp-fix-a11y-zones branch February 16, 2026 15:33
@github-project-automation github-project-automation bot moved this from Need Lead Dev Review to Done in 🟣 [Orange-Boosted-Bootstrap] PRs Board Feb 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Development

Successfully merging this pull request may close these issues.

3 participants