tests: Added unit test for card use-cases

OscarS05 · OscarS05 · commit 419d88908d10 · 2025-05-29T12:30:14.000-05:00
diff --git a/api/src/application/use-cases/card/CheckProjectMemberByCardAndList.js b/api/src/application/use-cases/card/CheckProjectMemberByCardAndList.js
@@ -6,12 +6,17 @@ class CheckProjectMemberByCardAndListUseCase {
   }
 
   async execute(userId, listId, cardId) {
+    if (!userId) throw new Error('userId was not provided');
+    if (!listId) throw new Error('listId was not provided');
+    if (!cardId) throw new Error('cardId was not provided');
+
     const card = await this.cardRepository.checkProjectMemberByCardAndList(
       userId,
       listId,
       cardId,
     );
-    return new CardDto(card);
+
+    return card?.id ? new CardDto(card) : {};
   }
 }
 
diff --git a/api/src/application/use-cases/card/CreateCardUseCase.js b/api/src/application/use-cases/card/CreateCardUseCase.js
@@ -7,8 +7,15 @@ class CreateCardUseCase {
   }
 
   async execute(listId, cardData) {
+    if (!listId) throw new Error('listId was not provided');
+
     const cardEntity = new CardEntity(cardData);
     const card = await this.cardRepository.create(listId, cardEntity);
+
+    if (!card?.id) {
+      throw new Error('Something went wrong creating the card.');
+    }
+
     return new CardDto(card);
   }
 }
diff --git a/api/src/application/use-cases/card/DeleteCardUseCase.js b/api/src/application/use-cases/card/DeleteCardUseCase.js
@@ -4,7 +4,17 @@ class DeleteCardUseCase {
   }
 
   async execute(cardId) {
-    return this.cardRepository.delete(cardId);
+    if (!cardId) throw new Error('cardId was not provided');
+
+    const result = await this.cardRepository.delete(cardId);
+
+    if (result === 0) {
+      throw new Error(
+        'Something went wrong deleting the card. Maybe the cardId does not exist',
+      );
+    }
+
+    return result;
   }
 }
 
diff --git a/api/src/application/use-cases/card/GetAllCardInformationUseCase.js b/api/src/application/use-cases/card/GetAllCardInformationUseCase.js
@@ -6,11 +6,15 @@ class GetAllCardInformationUseCase {
   }
 
   async execute(listId, cardId) {
+    if (!listId) throw new Error('listId was not provided');
+    if (!cardId) throw new Error('cardId was not provided');
+
     const card = await this.cardRepository.findAllCardInformation(
       listId,
       cardId,
     );
-    return CardDto.withAllCardInformation(card);
+
+    return card?.id ? CardDto.withAllCardInformation(card) : {};
   }
 }
 
diff --git a/api/src/application/use-cases/card/GetAllUseCase.js b/api/src/application/use-cases/card/GetAllUseCase.js
@@ -4,7 +4,11 @@ class GetAllUseCase {
   }
 
   async execute(listId) {
-    return this.cardRepository.findAll(listId);
+    if (!listId) throw new Error('listId was not provided');
+
+    const cards = await this.cardRepository.findAll(listId);
+
+    return cards?.length > 0 ? cards : [];
   }
 }
 
diff --git a/api/src/application/use-cases/card/GetCardUseCase.js b/api/src/application/use-cases/card/GetCardUseCase.js
@@ -6,8 +6,11 @@ class GetCardUseCase {
   }
 
   async execute(cardId) {
+    if (!cardId) throw new Error('cardId was not provided');
+
     const card = await this.cardRepository.findOneById(cardId);
-    return new CardDto(card);
+
+    return card?.id ? new CardDto(card) : {};
   }
 }
 
diff --git a/api/src/application/use-cases/card/GetProjectMemberByCardUseCase.js b/api/src/application/use-cases/card/GetProjectMemberByCardUseCase.js
@@ -9,11 +9,17 @@ class GetProjectMemberByCardUseCase {
   }
 
   async execute(userId, cardId) {
+    if (!userId) throw new Error('userId was not provided');
+    if (!cardId) throw new Error('cardId was not provided');
+
     const card = await this.cardRepository.findOneByIdWithList(cardId);
+
     if (!card?.id) throw boom.notFound('Card not found');
+
     const projectMember =
       await this.projectMemberRepository.getProjectMemberByCard(userId, card);
-    return new ProjectMemberDto(projectMember);
+
+    return projectMember?.id ? new ProjectMemberDto(projectMember) : {};
   }
 }
 
diff --git a/api/src/application/use-cases/card/UpdateCardUseCase.js b/api/src/application/use-cases/card/UpdateCardUseCase.js
@@ -9,6 +9,9 @@ class UpdateCardUseCase {
   }
 
   async execute(cardId, cardData) {
+    if (!cardId) throw new Error('cardId was not provided');
+    if (!cardData) throw new Error('cardData was not provided');
+
     const cardName = new CardName(cardData.newName).value;
     const cardDescription = new CardDescription(cardData.description).value;
 
diff --git a/api/src/domain/value-objects/cardDescription.js b/api/src/domain/value-objects/cardDescription.js
@@ -6,7 +6,6 @@ class CardDescription {
     this.value = value;
   }
 
-  // eslint-disable-next-line class-methods-use-this
   ensureIsValid(value) {
     if (typeof value !== 'string' || value.trim() === '') {
       throw boom.badData('CardDescription must be a non-empty string.');
@@ -16,9 +15,9 @@ class CardDescription {
     }
   }
 
-  get value() {
-    return this.value;
-  }
+  // get value() {
+  //   return this.value;
+  // }
 
   toString() {
     return this.value;
diff --git a/api/src/domain/value-objects/cardName.js b/api/src/domain/value-objects/cardName.js
@@ -8,7 +8,6 @@ class CardName {
     this.#value = value;
   }
 
-  // eslint-disable-next-line class-methods-use-this
   validate(value) {
     if (typeof value !== 'string' || value.trim() === '') {
       throw boom.badData('CardName must be a non-empty string.');
diff --git a/tests/unit/card/CheckProjectMemberByCardAndList.test.js b/tests/unit/card/CheckProjectMemberByCardAndList.test.js
@@ -0,0 +1,88 @@
+const CheckProjectMemberByCardAndList = require('../../../api/src/application/use-cases/card/CheckProjectMemberByCardAndList');
+const CardDto = require('../../../api/src/application/dtos/card.dto');
+const {
+  createCard,
+  createProjectMember,
+} = require('../../fake-data/fake-entities');
+
+describe('CheckProjectMemberByCardAndList', () => {
+  let userId;
+  let listId;
+  let cardId;
+  let dbResponse;
+  let mockCardRepository;
+  let checkProjectMemberByCardAndList;
+
+  beforeEach(() => {
+    userId = createProjectMember().userId;
+    listId = createCard().listId;
+    cardId = createCard().id;
+    dbResponse = createCard();
+
+    mockCardRepository = {
+      checkProjectMemberByCardAndList: jest.fn().mockResolvedValue(dbResponse),
+    };
+
+    checkProjectMemberByCardAndList = new CheckProjectMemberByCardAndList({
+      cardRepository: mockCardRepository,
+    });
+  });
+
+  test('It should return a card', async () => {
+    const result = await checkProjectMemberByCardAndList.execute(
+      userId,
+      cardId,
+      listId,
+    );
+
+    expect(
+      mockCardRepository.checkProjectMemberByCardAndList,
+    ).toHaveBeenCalledTimes(1);
+    expect(result).toMatchObject(new CardDto(dbResponse));
+  });
+
+  test('It should return an error because the userId was not provided', async () => {
+    await expect(
+      checkProjectMemberByCardAndList.execute(undefined, cardId, listId),
+    ).rejects.toThrow(/was not provided/);
+    expect(
+      mockCardRepository.checkProjectMemberByCardAndList,
+    ).not.toHaveBeenCalled();
+  });
+
+  test('It should return an error because the listId was not provided', async () => {
+    await expect(
+      checkProjectMemberByCardAndList.execute(userId, cardId, null),
+    ).rejects.toThrow(/was not provided/);
+    expect(
+      mockCardRepository.checkProjectMemberByCardAndList,
+    ).not.toHaveBeenCalled();
+  });
+
+  test('It should return an error because the cardId was not provided', async () => {
+    await expect(
+      checkProjectMemberByCardAndList.execute(userId, undefined, listId),
+    ).rejects.toThrow(/was not provided/);
+    expect(
+      mockCardRepository.checkProjectMemberByCardAndList,
+    ).not.toHaveBeenCalled();
+  });
+
+  test('It should return an empty object because the operation db failed', async () => {
+    mockCardRepository.checkProjectMemberByCardAndList.mockResolvedValue({});
+
+    const result = await checkProjectMemberByCardAndList.execute(
+      userId,
+      cardId,
+      listId,
+    );
+    expect(
+      mockCardRepository.checkProjectMemberByCardAndList,
+    ).toHaveBeenCalledTimes(1);
+    expect(result).toEqual({});
+  });
+
+  afterEach(() => {
+    jest.clearAllMocks();
+  });
+});
diff --git a/tests/unit/card/CreateCardUseCase.test.js b/tests/unit/card/CreateCardUseCase.test.js
@@ -0,0 +1,80 @@
+const CreateCardUseCase = require('../../../api/src/application/use-cases/card/CreateCardUseCase');
+const CardDto = require('../../../api/src/application/dtos/card.dto');
+const { createList, createCard } = require('../../fake-data/fake-entities');
+
+describe('CreateCardUseCase', () => {
+  let listId;
+  let cardData;
+  let dbResponse;
+  let mockCardRepository;
+  let createCardUseCase;
+
+  beforeEach(() => {
+    listId = createList().id;
+    cardData = createCard();
+    dbResponse = createCard();
+
+    mockCardRepository = {
+      create: jest.fn().mockResolvedValue(dbResponse),
+    };
+
+    createCardUseCase = new CreateCardUseCase({
+      cardRepository: mockCardRepository,
+    });
+  });
+
+  test('It should return a card', async () => {
+    const result = await createCardUseCase.execute(listId, cardData);
+
+    expect(mockCardRepository.create).toHaveBeenCalledTimes(1);
+    expect(result).toMatchObject(new CardDto(dbResponse));
+  });
+
+  test('It should return an error because the listId was not provided', async () => {
+    await expect(createCardUseCase.execute(null, cardData)).rejects.toThrow(
+      /was not provided/,
+    );
+    expect(mockCardRepository.create).not.toHaveBeenCalled();
+  });
+
+  test('It should return an error because name is not a string', async () => {
+    cardData.name = 213;
+
+    await expect(createCardUseCase.execute(listId, cardData)).rejects.toThrow(
+      /non-empty string/,
+    );
+    expect(mockCardRepository.create).not.toHaveBeenCalled();
+  });
+
+  test('It should return an error because the name exceed 80 characters', async () => {
+    cardData.name =
+      'jjjjjjjjjjjjjjjjjjjjjdddddddddddjjjjjjjjjjjjjjjjjjjjjjjjjjjjjdddddddddjjjjjjjjjdd';
+
+    await expect(createCardUseCase.execute(listId, cardData)).rejects.toThrow(
+      /exceed 80 characters/,
+    );
+    expect(mockCardRepository.create).not.toHaveBeenCalled();
+  });
+
+  test('It should return an error because description is not a string', async () => {
+    cardData.description = 213;
+
+    await expect(createCardUseCase.execute(listId, cardData)).rejects.toThrow(
+      /non-empty string/,
+    );
+    expect(mockCardRepository.create).not.toHaveBeenCalled();
+  });
+
+  test('It should return an error because the operation db failed', async () => {
+    mockCardRepository.create.mockResolvedValue(0);
+
+    await expect(createCardUseCase.execute(listId, cardData)).rejects.toThrow(
+      /Something went wrong/,
+    );
+    expect(mockCardRepository.create).toHaveBeenCalledTimes(1);
+  });
+
+  afterEach(() => {
+    jest.clearAllMocks();
+  });
+});
diff --git a/tests/unit/card/DeleteCardUseCase.test.js b/tests/unit/card/DeleteCardUseCase.test.js
@@ -0,0 +1,47 @@
+const DeleteCardUseCase = require('../../../api/src/application/use-cases/card/DeleteCardUseCase');
+const { createCard } = require('../../fake-data/fake-entities');
+
+describe('DeleteCardUseCase', () => {
+  let cardId;
+  let mockCardRepository;
+  let deleteCardUseCase;
+
+  beforeEach(() => {
+    cardId = createCard().id;
+
+    mockCardRepository = {
+      delete: jest.fn().mockResolvedValue(1),
+    };
+
+    deleteCardUseCase = new DeleteCardUseCase({
+      cardRepository: mockCardRepository,
+    });
+  });
+
+  test('It should return a 1', async () => {
+    const result = await deleteCardUseCase.execute(cardId);
+
+    expect(mockCardRepository.delete).toHaveBeenCalledTimes(1);
+    expect(result).toBe(1);
+  });
+
+  test('It should return an error because the cardId was not provided', async () => {
+    await expect(deleteCardUseCase.execute(null)).rejects.toThrow(
+      /was not provided/,
+    );
+    expect(mockCardRepository.delete).not.toHaveBeenCalled();
+  });
+
+  test('It should return an error because the operation db failed', async () => {
+    mockCardRepository.delete.mockResolvedValue(0);
+
+    await expect(deleteCardUseCase.execute(cardId)).rejects.toThrow(
+      /Something went wrong|Zero rows deleted/,
+    );
+    expect(mockCardRepository.delete).toHaveBeenCalledTimes(1);
+  });
+
+  afterEach(() => {
+    jest.clearAllMocks();
+  });
+});
diff --git a/tests/unit/card/GetAllCardInformationUseCase.test.js b/tests/unit/card/GetAllCardInformationUseCase.test.js
diff --git a/tests/unit/card/GetAllCardsUseCase.test.js b/tests/unit/card/GetAllCardsUseCase.test.js
diff --git a/tests/unit/card/GetCardUseCase.test.js b/tests/unit/card/GetCardUseCase.test.js
diff --git a/tests/unit/card/GetProjectMemberByCardUseCase.test.js b/tests/unit/card/GetProjectMemberByCardUseCase.test.js
diff --git a/tests/unit/card/UpdateCardUseCase.test.js b/tests/unit/card/UpdateCardUseCase.test.js
diff --git a/tests/unit/list/CheckProjectMembershipByListUseCase.test.js b/tests/unit/list/CheckProjectMembershipByListUseCase.test.js

Original file line number	Diff line number	Diff line change
`@@ -6,12 +6,17 @@ class CheckProjectMemberByCardAndListUseCase {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`async execute(userId, listId, cardId) {`
	`9`	`+ if (!userId) throw new Error('userId was not provided');`
	`10`	`+ if (!listId) throw new Error('listId was not provided');`
	`11`	`+ if (!cardId) throw new Error('cardId was not provided');`
	`12`	`+`
`9`	`13`	`const card = await this.cardRepository.checkProjectMemberByCardAndList(`
`10`	`14`	`userId,`
`11`	`15`	`listId,`
`12`	`16`	`cardId,`
`13`	`17`	`);`
`14`		`- return new CardDto(card);`
	`18`	`+`
	`19`	`+ return card?.id ? new CardDto(card) : {};`
`15`	`20`	`}`
`16`	`21`	`}`
`17`	`22`
Original file line number	Diff line number	Diff line change
`@@ -7,8 +7,15 @@ class CreateCardUseCase {`
`7`	`7`	`}`
`8`	`8`
`9`	`9`	`async execute(listId, cardData) {`
	`10`	`+ if (!listId) throw new Error('listId was not provided');`
	`11`	`+`
`10`	`12`	`const cardEntity = new CardEntity(cardData);`
`11`	`13`	`const card = await this.cardRepository.create(listId, cardEntity);`
	`14`	`+`
	`15`	`+ if (!card?.id) {`
	`16`	`+ throw new Error('Something went wrong creating the card.');`
	`17`	`+ }`
	`18`	`+`
`12`	`19`	`return new CardDto(card);`
`13`	`20`	`}`
`14`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,17 @@ class DeleteCardUseCase {`
`4`	`4`	`}`
`5`	`5`
`6`	`6`	`async execute(cardId) {`
`7`		`- return this.cardRepository.delete(cardId);`
	`7`	`+ if (!cardId) throw new Error('cardId was not provided');`
	`8`	`+`
	`9`	`+ const result = await this.cardRepository.delete(cardId);`
	`10`	`+`
	`11`	`+ if (result === 0) {`
	`12`	`+ throw new Error(`
	`13`	`+ 'Something went wrong deleting the card. Maybe the cardId does not exist',`
	`14`	`+ );`
	`15`	`+ }`
	`16`	`+`
	`17`	`+ return result;`
`8`	`18`	`}`
`9`	`19`	`}`
`10`	`20`
Original file line number	Diff line number	Diff line change
`@@ -6,11 +6,15 @@ class GetAllCardInformationUseCase {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`async execute(listId, cardId) {`
	`9`	`+ if (!listId) throw new Error('listId was not provided');`
	`10`	`+ if (!cardId) throw new Error('cardId was not provided');`
	`11`	`+`
`9`	`12`	`const card = await this.cardRepository.findAllCardInformation(`
`10`	`13`	`listId,`
`11`	`14`	`cardId,`
`12`	`15`	`);`
`13`		`- return CardDto.withAllCardInformation(card);`
	`16`	`+`
	`17`	`+ return card?.id ? CardDto.withAllCardInformation(card) : {};`
`14`	`18`	`}`
`15`	`19`	`}`
`16`	`20`
Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,11 @@ class GetAllUseCase {`
`4`	`4`	`}`
`5`	`5`
`6`	`6`	`async execute(listId) {`
`7`		`- return this.cardRepository.findAll(listId);`
	`7`	`+ if (!listId) throw new Error('listId was not provided');`
	`8`	`+`
	`9`	`+ const cards = await this.cardRepository.findAll(listId);`
	`10`	`+`
	`11`	`+ return cards?.length > 0 ? cards : [];`
`8`	`12`	`}`
`9`	`13`	`}`
`10`	`14`
Original file line number	Diff line number	Diff line change
`@@ -6,8 +6,11 @@ class GetCardUseCase {`
`6`	`6`	`}`
`7`	`7`
`8`	`8`	`async execute(cardId) {`
	`9`	`+ if (!cardId) throw new Error('cardId was not provided');`
	`10`	`+`
`9`	`11`	`const card = await this.cardRepository.findOneById(cardId);`
`10`		`- return new CardDto(card);`
	`12`	`+`
	`13`	`+ return card?.id ? new CardDto(card) : {};`
`11`	`14`	`}`
`12`	`15`	`}`
`13`	`16`
Original file line number	Diff line number	Diff line change
`@@ -9,11 +9,17 @@ class GetProjectMemberByCardUseCase {`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`async execute(userId, cardId) {`
	`12`	`+ if (!userId) throw new Error('userId was not provided');`
	`13`	`+ if (!cardId) throw new Error('cardId was not provided');`
	`14`	`+`
`12`	`15`	`const card = await this.cardRepository.findOneByIdWithList(cardId);`
	`16`	`+`
`13`	`17`	`if (!card?.id) throw boom.notFound('Card not found');`
	`18`	`+`
`14`	`19`	`const projectMember =`
`15`	`20`	`await this.projectMemberRepository.getProjectMemberByCard(userId, card);`
`16`		`- return new ProjectMemberDto(projectMember);`
	`21`	`+`
	`22`	`+ return projectMember?.id ? new ProjectMemberDto(projectMember) : {};`
`17`	`23`	`}`
`18`	`24`	`}`
`19`	`25`
Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,9 @@ class UpdateCardUseCase {`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`async execute(cardId, cardData) {`
	`12`	`+ if (!cardId) throw new Error('cardId was not provided');`
	`13`	`+ if (!cardData) throw new Error('cardData was not provided');`
	`14`	`+`
`12`	`15`	`const cardName = new CardName(cardData.newName).value;`
`13`	`16`	`const cardDescription = new CardDescription(cardData.description).value;`
`14`	`17`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,6 @@ class CardDescription {`
`6`	`6`	`this.value = value;`
`7`	`7`	`}`
`8`	`8`
`9`		`- // eslint-disable-next-line class-methods-use-this`
`10`	`9`	`ensureIsValid(value) {`
`11`	`10`	`if (typeof value !== 'string' \|\| value.trim() === '') {`
`12`	`11`	`throw boom.badData('CardDescription must be a non-empty string.');`
`@@ -16,9 +15,9 @@ class CardDescription {`
`16`	`15`	`}`
`17`	`16`	`}`
`18`	`17`
`19`		`- get value() {`
`20`		`- return this.value;`
`21`		`- }`
	`18`	`+ // get value() {`
	`19`	`+ // return this.value;`
	`20`	`+ // }`
`22`	`21`
`23`	`22`	`toString() {`
`24`	`23`	`return this.value;`
Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,6 @@ class CardName {`
`8`	`8`	`this.#value = value;`
`9`	`9`	`}`
`10`	`10`
`11`		`- // eslint-disable-next-line class-methods-use-this`
`12`	`11`	`validate(value) {`
`13`	`12`	`if (typeof value !== 'string' \|\| value.trim() === '') {`
`14`	`13`	`throw boom.badData('CardName must be a non-empty string.');`