tests: Added e2e testing for checklist item endpoints

Author: OscarS05

api/src/application/services/checklist-item.service.js

@@ -43,16 +43,17 @@ class ChecklistItemService {
         checklistItemData.assignedProjectMemberIds,
         requesterAsProjectMember.projectId,
       );
-    }
 
-    if (projectMembers.length === 0)
-      throw boom.badData(
-        'The provided project member ids do not belong to the project',
+      if (projectMembers?.length === 0)
+        throw boom.badData(
+          'The provided project member ids do not belong to the project',
+        );
+
+      checklistItemData.assignedProjectMemberIds = projectMembers.map(
+        (member) => member.id,
       );
+    }
 
-    checklistItemData.assignedProjectMemberIds = projectMembers.map(
-      (member) => member.id,
-    );
     return this.createChecklistItemUseCase.execute(checklistItemData);
   }
 

api/src/application/use-cases/checklist-item/UpdateTheCheckOfItemUseCase.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-param-reassign */
 const boom = require('@hapi/boom');
 const ChecklistItemDto = require('../../dtos/checklist-item.dto');
 
@@ -9,9 +10,14 @@ class UpdateTheCheckOfItemUseCase {
   async execute(checklistItemId, isChecked) {
     if (!checklistItemId) throw new Error('checklistItemId was not provided');
     if (typeof isChecked !== 'boolean') {
-      throw new Error('checklistItemId was not provided');
+      if (isChecked !== 'false' && isChecked !== 'true') {
+        throw new Error('isChecked was not provided');
+      }
     }
 
+    if (isChecked === 'false') isChecked = false;
+    if (isChecked === 'true') isChecked = true;
+
     const [affectedRows, [updateChecklistItem]] =
       await this.checklistItemRepository.update(checklistItemId, { isChecked });
 

api/src/infrastructure/repositories/db/checklist-item.repository.js

@@ -28,20 +28,25 @@ class ChecklistItemRepository extends IChecklistItemRepository {
   }
 
   async findOneByIdAndProject(checklistItemId, projectId) {
+    console.log(checklistItemId, projectId);
+
     return this.db.models.ChecklistItem.findOne({
       where: { id: checklistItemId },
       include: [
         {
           model: this.db.models.Checklist,
           as: 'checklist',
+          required: true,
           include: [
             {
               model: this.db.models.Card,
               as: 'card',
+              required: true,
               include: [
                 {
                   model: this.db.models.List,
                   as: 'list',
+                  required: true,
                   where: { projectId },
                 },
               ],

api/src/interfaces/controllers/checklist-item.controller.js

@@ -87,14 +87,14 @@ const deleteChecklistItem = async (req, res, next) => {
     const { checklistItemId } = req.params;
     const requesterAsProjectMember = req.projectMember;
 
-    const deletedCard = await checklistItemService.deleteChecklistItem(
+    const deletedItem = await checklistItemService.deleteChecklistItem(
       requesterAsProjectMember,
       checklistItemId,
     );
 
     res.status(200).json({
       message: 'The checklist item was successfully removed',
-      deletedCard,
+      deletedItem,
     });
   } catch (error) {
     next(error);

api/src/interfaces/schemas/checklist-item.schema.js

@@ -1,7 +1,15 @@
 const Joi = require('joi');
 
 const id = Joi.string().uuid();
-const name = Joi.string().trim().min(1).max(50);
+const name = Joi.string()
+  .trim()
+  .min(1)
+  .max(50)
+  .pattern(/^(?!.*\.\.)(?![. ])([A-Za-z0-9 _.-]{3,80})(?<![. ])$/)
+  .messages({
+    'string.pattern.base':
+      'The name can only contain letters, numbers and spaces.',
+  });
 const dueDate = Joi.date().iso().greater('now').messages({
   'date.format': 'Due date must be a valid ISO date string',
   'date.greater': 'Due date must be in the future',