-
Notifications
You must be signed in to change notification settings - Fork 5
Feat/adding memory layer #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OtherVibes
reviewed
Sep 6, 2025
OtherVibes
requested changes
Sep 6, 2025
| SQLModel.metadata.create_all(self.engine) | ||
| logger.info("π Created conversation_history table with SQLModel") | ||
|
|
||
| def _cleanup_old_records(self) -> int: |
Owner
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to limit by record count and not by date with FIFO strategy
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are 2 clean logic
- remain only X records and when x+1 msg arrive we remove first item and add new one in the end
- daily cleanup as in memory storage does not clean when session ends - we dont know when it ends
OtherVibes
requested changes
Sep 7, 2025
OtherVibes
reviewed
Sep 7, 2025
OtherVibes
reviewed
Sep 7, 2025
OtherVibes
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Brief description of the changes in this PR.
Type of Change
Testing
Checklist
Related Issues
Closes #(issue number)
Screenshots (if applicable)
Additional Notes
Any additional information that reviewers should know.