Skip to content

Conversation

@doriwal
Copy link
Collaborator

@doriwal doriwal commented Sep 6, 2025

Description

Brief description of the changes in this PR.

Type of Change

  • πŸ› Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • πŸ’₯ Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • πŸ“š Documentation update
  • πŸ”§ Maintenance/refactoring
  • ⚑ Performance improvement
  • πŸ§ͺ Test improvement

Testing

  • Tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Related Issues

Closes #(issue number)

Screenshots (if applicable)

Additional Notes

Any additional information that reviewers should know.

@doriwal doriwal requested a review from OtherVibes as a code owner September 6, 2025 21:58
SQLModel.metadata.create_all(self.engine)
logger.info("πŸ“‹ Created conversation_history table with SQLModel")

def _cleanup_old_records(self) -> int:
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to limit by record count and not by date with FIFO strategy

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 clean logic

  1. remain only X records and when x+1 msg arrive we remove first item and add new one in the end
  2. daily cleanup as in memory storage does not clean when session ends - we dont know when it ends

@OtherVibes OtherVibes self-assigned this Sep 7, 2025
@OtherVibes OtherVibes assigned doriwal and unassigned OtherVibes Sep 7, 2025
@OtherVibes OtherVibes merged commit 6919eb1 into main Sep 7, 2025
9 checks passed
@OtherVibes OtherVibes deleted the feat/adding_memory_layer branch September 7, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants