Fixed incorrect blit viewport size (#542)

adriengivry · web-flow · commit 7b2705d6e541 · 2025-05-19T21:33:38.000-04:00
diff --git a/Sources/Overload/OvRendering/src/OvRendering/Core/ABaseRenderer.cpp b/Sources/Overload/OvRendering/src/OvRendering/Core/ABaseRenderer.cpp
@@ -131,7 +131,7 @@ void OvRendering::Core::ABaseRenderer::Blit(
 {
 	ZoneScoped;
 
-	auto [srcWidth, srcHeight] = p_src.GetSize();
+	const auto [srcWidth, srcHeight] = p_src.GetSize();
 
 	if (OvRendering::Settings::IsFlagSet(OvRendering::Settings::EBlitFlags::RESIZE_DST_TO_MATCH_SRC, p_flags))
 	{
@@ -168,7 +168,8 @@ void OvRendering::Core::ABaseRenderer::Blit(
 
 	if (OvRendering::Settings::IsFlagSet(OvRendering::Settings::EBlitFlags::UPDATE_VIEWPORT_SIZE, p_flags))
 	{
-		SetViewport(0, 0, srcWidth, srcHeight);
+		const auto [dstWidth, dstHeight] = p_dst.GetSize();
+		SetViewport(0, 0, dstWidth, dstHeight);
 	}
 
 	DrawEntity(p_pso, blit);

Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,7 @@ void OvRendering::Core::ABaseRenderer::Blit(`
`131`	`131`	`{`
`132`	`132`	`ZoneScoped;`
`133`	`133`
`134`		`- auto [srcWidth, srcHeight] = p_src.GetSize();`
	`134`	`+ const auto [srcWidth, srcHeight] = p_src.GetSize();`
`135`	`135`
`136`	`136`	`if (OvRendering::Settings::IsFlagSet(OvRendering::Settings::EBlitFlags::RESIZE_DST_TO_MATCH_SRC, p_flags))`
`137`	`137`	`{`
`@@ -168,7 +168,8 @@ void OvRendering::Core::ABaseRenderer::Blit(`
`168`	`168`
`169`	`169`	`if (OvRendering::Settings::IsFlagSet(OvRendering::Settings::EBlitFlags::UPDATE_VIEWPORT_SIZE, p_flags))`
`170`	`170`	`{`
`171`		`- SetViewport(0, 0, srcWidth, srcHeight);`
	`171`	`+ const auto [dstWidth, dstHeight] = p_dst.GetSize();`
	`172`	`+ SetViewport(0, 0, dstWidth, dstHeight);`
`172`	`173`	`}`
`173`	`174`
`174`	`175`	`DrawEntity(p_pso, blit);`