Fixed material deserialize didn't reset properties and features properly (#535)

adriengivry · web-flow · commit 8249067ca536 · 2025-05-17T13:22:48.000-04:00
diff --git a/Sources/Overload/OvCore/src/OvCore/Resources/Material.cpp b/Sources/Overload/OvCore/src/OvCore/Resources/Material.cpp
@@ -145,6 +145,8 @@ void OvCore::Resources::Material::OnDeserialize(tinyxml2::XMLDocument& p_doc, ti
 	/* We get the shader with Deserialize method */
 	const auto shader = Serializer::DeserializeShader(p_doc, p_node, "shader");
 
+	m_properties.clear();
+
 	/* We verify that the shader is valid (Not null) */
 	if (shader)
 	{
@@ -210,6 +212,8 @@ void OvCore::Resources::Material::OnDeserialize(tinyxml2::XMLDocument& p_doc, ti
 		}
 	}
 
+	m_features.clear();
+
 	const auto features = Serializer::DeserializeString(p_doc, p_node, "features");
 
 	// Parse features (comma-separated)

Original file line number	Diff line number	Diff line change
`@@ -145,6 +145,8 @@ void OvCore::Resources::Material::OnDeserialize(tinyxml2::XMLDocument& p_doc, ti`
`145`	`145`	`/* We get the shader with Deserialize method */`
`146`	`146`	`const auto shader = Serializer::DeserializeShader(p_doc, p_node, "shader");`
`147`	`147`
	`148`	`+ m_properties.clear();`
	`149`	`+`
`148`	`150`	`/* We verify that the shader is valid (Not null) */`
`149`	`151`	`if (shader)`
`150`	`152`	`{`
`@@ -210,6 +212,8 @@ void OvCore::Resources::Material::OnDeserialize(tinyxml2::XMLDocument& p_doc, ti`
`210`	`212`	`}`
`211`	`213`	`}`
`212`	`214`
	`215`	`+ m_features.clear();`
	`216`	`+`
`213`	`217`	`const auto features = Serializer::DeserializeString(p_doc, p_node, "features");`
`214`	`218`
`215`	`219`	`// Parse features (comma-separated)`