Skip to content

Various fixes and cleanup for post-process pass #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

adriengivry
Copy link
Member

Description

  • Bloom pass now outputs an alpha of 1.0f, preventing the post-process pass to finish with a framebuffer with alpha 0.0f if only bloom is enabled (resulting in the editor view displaying a transparent scene output)
  • Updated auto-exposure effect and post-process pass to use the PingPongFramebuffer
  • Re-ordered post-process stack component inspector settings to match pass order (auto-exposure --> bloom --> tonemapping --> FXAA)
  • Fixed potential state leak between frames (pipeline state wasn't reset after the frame was completed)

Related Issue(s)

N/A

Review Guidance

Write here.

Screenshots/GIFs

Write here.

@adriengivry adriengivry self-assigned this May 22, 2025
@adriengivry adriengivry added Graphics Graphical feature Cleanup Code cleanup labels May 22, 2025
@adriengivry adriengivry changed the title [WIP] Various fixes and cleanup for post-process pass Various fixes and cleanup for post-process pass May 23, 2025
@adriengivry adriengivry marked this pull request as ready for review May 23, 2025 00:15
@adriengivry adriengivry merged commit bb1a613 into main May 23, 2025
1 check passed
@adriengivry adriengivry deleted the fix/post_process_pass branch May 23, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Code cleanup Graphics Graphical feature
Development

Successfully merging this pull request may close these issues.

1 participant