Refactor: Downloader #130
Closed
Refactor: Downloader #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitecat346
requested changes
Jun 12, 2025
Comment on lines
+24
to
+28
| public static readonly MojangJavaVersion A = new("java-runtime-alpha"); | ||
| public static readonly MojangJavaVersion Β = new("java-runtime-beta"); | ||
| public static readonly MojangJavaVersion Δ = new("java-runtime-delta"); | ||
| public static readonly MojangJavaVersion Γ = new("java-runtime-gamma"); | ||
| public static readonly MojangJavaVersion Γs = new("java-runtime-gamma-snapshot"); |
There was a problem hiding this comment.
修改为英文Alpla,Beta,Gamma,Delta
禁止使用非ASCII字符
| } | ||
| catch (IOException e) | ||
| { | ||
| // TODO: handle this storage space is run out exception |
There was a problem hiding this comment.
完成TODO的内容（其余TODO的req-review相同）
Comment on lines
+122
to
+136
| // ERROR: TODO: i cant understand this codes... | ||
| // await using var lzmaFs = await DownloadReceipt.FastDownloadAsStreamAsync(urlLzma, | ||
| // localFilePath + ".lzma", sha1Lzma, cancellationToken); | ||
| // await using var fs = lzmaFs.DecompressLzma(localFilePath); | ||
| // if (fs is null) | ||
| // { | ||
| // Console.WriteLine("outStream 为空"); | ||
| // return; | ||
| // } | ||
| // | ||
| // if (!await new FileIntegrity { Hash = sha1Raw }.VerifyAsync(fs, cancellationToken)) | ||
| // { | ||
| // Console.WriteLine("解压后的文件SHA-1与源提供的不匹配"); | ||
| // return; | ||
| // } |
Comment on lines
+151
to
+153
| // TODO: i cant understand this codes... | ||
|
|
||
| //ERROR: tasks.Add(DownloadReceipt.FastDownloadAsync(urlRaw, localFilePath, sha1Raw, cancellationToken)); |
Comment on lines
+27
to
+38
| <ItemGroup> | ||
| <Compile Remove="Download\Minercraft\**" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <EmbeddedResource Remove="Download\Minercraft\**" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <None Remove="Download\Minercraft\**" /> | ||
| </ItemGroup> | ||
|
|
|
Closed as no planned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #124