Conversation
TheLastRar
reviewed
May 18, 2025
CMakeLists.txt
Outdated
| add_subdirectory(updater) | ||
| endif() | ||
|
|
||
| add_subdirectory(pcsx2-gsrunner EXCLUDE_FROM_ALL) |
Contributor
There was a problem hiding this comment.
We check a flag ENABLE_GSRUNNER a little below in the same file
The warning it prints will need to be updated, however.
Member
Author
There was a problem hiding this comment.
The fun of leaving patches sitting around for years and then rebasing them
Should be fixed
TellowKrinkle
force-pushed
the
MacGSRunner
branch
from
730b15d to
b71b279
Compare
F0bes
approved these changes
May 29, 2025
TellowKrinkle
force-pushed
the
MacGSRunner
branch
from
b71b279 to
ee5d32a
Compare
Member
Author
Not sure, we need the metallibs to get copied in too, which are part of the pcsx2-qt target |
F0bes
requested changes
Jun 1, 2025
F0bes
approved these changes
Jun 5, 2025
Member
F0bes
left a comment
F0bes
left a comment
There was a problem hiding this comment.
Tested on macOS and Windows. Both seem to continue to work normally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Supports running the gsdump runner on macOS
Note: Since the gsdump runner is not in an application bundle, it will search for a
resourcesdirectory in the same directory as it, similar to how the main PCSX2 exe works on Windows.Rationale behind Changes
It's nice to have a working GSdump runner
Suggested Testing Steps
Test the GSdump runner on macOS
(Note: I tested a while back and it worked then, but then I rebased it without testing so please test)Edit: I tested it, it now works without crashing on shutdown.
Did you use AI to help find, test, or implement this issue or feature?
No