MemoryCard: Fix crash when attempting to save read only file.#12694
Closed
lightningterror wants to merge 1 commit intomasterfrom
Closed
MemoryCard: Fix crash when attempting to save read only file.#12694lightningterror wants to merge 1 commit intomasterfrom
lightningterror wants to merge 1 commit intomasterfrom
Conversation
JordanTheToaster
approved these changes
May 22, 2025
Contributor
Author
|
Closing as this isn't a good solution even tho it solves the crash, there's a better way to handle this which pandubz has some ideas for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
MemoryCard: Fix crash when attempting to save read only file.
Rationale behind Changes
Crash fix/bugfix.
Fixes #12658
Suggested Testing Steps
Use folder memory cards, make the location read only, try to save and see if it crashes, see if any log messages appear when failing to save.