GS:SW: Use accurate fog equation #13171
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested this on the linked GS dump and ran homedrew tests to compare fogging with PS2. Fogging on SW renderer appears to be hardware accurate now. |
JordanTheToaster
approved these changes
Aug 27, 2025
|
Someone with a way to compare images would have to compare, but I think zooming in toward the background, there is a slight difference in fog here between SW master and SW PR. MGS2 Big Shell cutscene (used the Shell 2 strut in the distant background to the left of the Shell 1 core as a reference): Jak 3 title screen (used the mountain the distant background on the left as reference): Also randomly tested SSX 3, Iron Man, ATV: Offroad Fury, and OutRun 2006 and saw no regressions. |
TheTechnician27
approved these changes
Aug 30, 2025
TellowKrinkle
force-pushed
the
AccurateFog
branch
2 times, most recently
from
f4cc23f to
42d74b3
Compare
TellowKrinkle
force-pushed
the
AccurateFog
branch
from
42d74b3 to
3139e8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Avoids using the mulhrsw instruction, since it rounds instead of truncating
Fixes #5898
Helps #11477
Rationale behind Changes
Accurate fog
Suggested Testing Steps
Test the things in the referenced issues
Did you use AI to help find, test, or implement this issue or feature?
Running copilot helped remind me that we had an ARM implementation that needed fixing as well