Skip to content

Conversation

@PhilipDeegan
Copy link
Member

given to close

#1059
#1044
#1043

@coderabbitai
Copy link

coderabbitai bot commented Aug 6, 2025

Important

Review skipped

Ignore keyword(s) in the title.

⛔ Ignored keywords (1)
  • WIP

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@PhilipDeegan PhilipDeegan force-pushed the resman branch 5 times, most recently from 1eca4ac to a6adedb Compare August 6, 2025 19:25
endif()
####

include("${PHARE_PROJECT_DIR}/res/cmake/test.cmake")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having this first, will cause the tests to be built before some phare binaries, like the python modules, which take a while to link, and if the tests fail to compile then there's no point in building anything else I think

return sim.time_step * np.arange(nbr_dump_step)
init_time = sim.start_time()
nbr_dump_step = int((sim.final_time - init_time) / sim.time_step) + 1
return (sim.time_step * np.arange(nbr_dump_step)) + init_time
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated to work with restarts

@PhilipDeegan PhilipDeegan changed the title WIP single resource manager single resource manager Oct 31, 2025
@nicolasaunai nicolasaunai merged commit ffccf14 into PHAREHUB:master Nov 5, 2025
13 checks passed
@PhilipDeegan PhilipDeegan deleted the resman branch November 5, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants