-
Notifications
You must be signed in to change notification settings - Fork 30
single resource manager #1072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
single resource manager #1072
Conversation
|
Important Review skippedIgnore keyword(s) in the title. ⛔ Ignored keywords (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1eca4ac to
a6adedb
Compare
| endif() | ||
| #### | ||
|
|
||
| include("${PHARE_PROJECT_DIR}/res/cmake/test.cmake") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having this first, will cause the tests to be built before some phare binaries, like the python modules, which take a while to link, and if the tests fail to compile then there's no point in building anything else I think
| return sim.time_step * np.arange(nbr_dump_step) | ||
| init_time = sim.start_time() | ||
| nbr_dump_step = int((sim.final_time - init_time) / sim.time_step) + 1 | ||
| return (sim.time_step * np.arange(nbr_dump_step)) + init_time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to work with restarts
given to close
#1059
#1044
#1043