Merge pull request #11 from PHPCSStandards/feature/minor-tweaks

UpdateXsdFiles: minor tweaks

Author: jrfnl

src/Build/UpdateXsdFiles.php

@@ -142,20 +142,16 @@ private function getReleasesFallback(): void
         $releasesJson = \curl_exec($curl);
 
         if (\is_string($releasesJson) === false) {
-            \curl_close($curl);
             throw new RuntimeException('GitHub API request to retrieve the releases failed');
         }
 
         \curl_setopt($curl, \CURLOPT_URL, self::API_LATEST_TAG_URL);
         $latestReleaseJson = \curl_exec($curl);
 
         if (\is_string($latestReleaseJson) === false) {
-            \curl_close($curl);
             throw new RuntimeException('GitHub API request to retrieve the latest release failed');
         }
 
-        \curl_close($curl);
-
         $latestRelease = \json_decode($latestReleaseJson, flags: \JSON_THROW_ON_ERROR | \JSON_OBJECT_AS_ARRAY);
         $latestRelease = $latestRelease['tag_name'];
 
@@ -230,7 +226,7 @@ private function getXsdFile(string $tagName): string
     {
         $url      = \sprintf(self::XSD_URL, $tagName);
         $contents = \file_get_contents($url);
-        if (!$contents) {
+        if (is_string($contents) === false) {
             throw new RuntimeException(\sprintf('Failed to read XSD file: %s', $url));
         }