Skip to content

Unfinished Business WIth (Cell)ReferenceHelper After Columns/Rows Deleted #4379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oleibman opened this issue Feb 22, 2025 · 0 comments
Open

Comments

@oleibman
Copy link
Collaborator

oleibman commented Feb 22, 2025

After a very long delay, PR #3528 has been moved to ready status, and will be installed soon, warts and all. And it has warts aplenty. It fixes some problem, and doesn't break anything. But it leaves some outstanding problems. In the hope that dealing with those will be easier if they are addressed in bite-sized pieces, I am opening this ticket to document what is missing.

oleibman added a commit to oleibman/PhpSpreadsheet that referenced this issue May 10, 2025
Fix PHPOffice#282, which went stale over 7 years ago, and is now reopened. This is certainly related to issue PHPOffice#4379. If merged cells are in the midst of deleted rows/columns, the merge may continue to exist after the deletion, leading to various problems including spreadsheet corruption. The problem is not with either Reader or Writer.

This PR will automatically unmerge all merged cells whose first cell is in the delete range before performing the deletion. This will address the corruption problem. Something more sophisticated may be required, so I won't merge this PR for a while to give me a chance to think about it some more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant