Skip to content

More Phpstan Level 10 Prep - Writers #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025
Merged

Conversation

oleibman
Copy link
Collaborator

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests
  • code quality

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Why this change is needed?

Ongoing maintenance to eventually get to Phpstan Level 10.

@oleibman
Copy link
Collaborator Author

Scrutinizer unable to handle doctype declarations like array{int, int}. 19 such messages suppressed. One method's complexity went from C to D; no concern whatever about this.

@oleibman oleibman added this pull request to the merge queue Apr 30, 2025
Merged via the queue into PHPOffice:master with commit c886276 Apr 30, 2025
13 of 14 checks passed
@oleibman oleibman deleted the stan1003write branch April 30, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant