Skip to content

Conversation

@damhuonglan
Copy link
Contributor

@damhuonglan damhuonglan commented Oct 13, 2021

What does this PR do?

In the past, when pn4 format was introduced, pn3 data has been converted using the protocol: https://github.com/PIC-IRIS/PH5/wiki/Using-Obspy-to--load-data-into-PH5
However, when ph5validate was updated, there are a couple of pn3-converted-to-pn4 data sets found corrupted because of the inconsistency between array_t, index_t, das_t or invalid entries in array_t.
This PR will eliminate the inconsistent entries in those three tables and recreate them for pn4 data set.
The waveform data without metadata will be kept in minifile without external links. Later, when metadata are found, external links can be created using a tool named "create_ext" which will be build after this PR.
If there are fields of which values need to be added similarly in array_t, add the info in a file and use flag -a.
In this PR, ph5validate has been modified to fix bug happening when there are identical entries (not include station_id) in the same array. This bug will be fixed in another PR but temporarily put here for user to validate data after they use this tool. The commit for this (f129bca) will be reverted before merging the bug fix to this PR.

Requirements

Remember to install new command using pip install -e . in ph5 conda environment, under PH5 root folder.

  • A directory that keeps all pn3 data.
  • A directory that keeps master.ph5 from pn4 data

Command Example

correctwpn3 --pn4 pn4 --pn3 pn3 -a addInfo.txt
Flag -S can be used if you don't want the tool to ask for your response to continue or not

Checklist

  • This PR is not directly related to an existing issue (which has no PR yet).
  • All tests pass.
  • Any new or changed features have are documented.
  • Changes have been added to CHANGELOG.txt .
  • First time contributors have added your name to CONTRIBUTORS.txt .

@timronan timronan self-requested a review November 16, 2021 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants