[Prim][CINN] Fix group_norm_grad decomp sum dtype #73037
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Category
Operator Mechanism
PR Types
Bug fixes
Description
修复
group_norm_grad
组合算子拆解中sum的dtype设置错误的问题,即半精度下应当基于float类型进行sum,解决test_group_norm_op_deprecated
单测的精度问题(这个单测在CI里不跑,只能手动验证)参考layer_norm_grad:
Paddle/paddle/fluid/primitive/decomp_rule/decomp_vjp/details.h
Lines 896 to 901 in 4f9d17a
检查了下另外几个batch_norm/layer_norm/instance_norm的反向都是对的,为啥只有group_norm_grad是错的
Pcard-85711