Skip to content

Conversation

@zhangyuqin1998
Copy link
Contributor

@zhangyuqin1998 zhangyuqin1998 commented Oct 30, 2025

…efine training_pipeline_step to avoid memory leaks

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Others

PR changes

Others

Description

Support param and moment sync for pp && refine training_pipeline_step to avoid memory leaks
cp from PaddlePaddle/PaddleNLP#11103 and PaddlePaddle/PaddleNLP#11046

…efine training_pipeline_step to avoid memory leaks
@paddle-bot
Copy link

paddle-bot bot commented Oct 30, 2025

Thanks for your contribution!

@zhangyuqin1998 zhangyuqin1998 changed the title [[PaddleNLP->PaddleFormers] Support param and moment sync for pp && r… [[PaddleNLP->PaddleFormers] Support param and moment sync for pp && refine training_pipeline_step to avoid memory leaks Oct 30, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 10.00000% with 18 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@d9e0dbc). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/trainer/trainer.py 16.66% 10 Missing ⚠️
paddleformers/trainer/training_args.py 0.00% 8 Missing ⚠️

❌ Your patch status has failed because the patch coverage (10.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2816   +/-   ##
==========================================
  Coverage           ?   29.22%           
==========================================
  Files              ?      335           
  Lines              ?    56335           
  Branches           ?        0           
==========================================
  Hits               ?    16464           
  Misses             ?    39871           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@miao200years miao200years left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@miao200years miao200years merged commit 38c47d4 into PaddlePaddle:develop Oct 30, 2025
5 checks passed
BossPi pushed a commit to BossPi/PaddleFormers that referenced this pull request Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants