Skip to content

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Oct 30, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Others

PR changes

Others

Description

Cherry-pick PaddlePaddle/PaddleNLP#11075 and PaddlePaddle/PaddleNLP#11049.

@paddle-bot
Copy link

paddle-bot bot commented Oct 30, 2025

Thanks for your contribution!

@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 8.88889% with 41 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@38c47d4). Learn more about missing BASE report.

Files with missing lines Patch % Lines
paddleformers/trainer/utils/sharding_io.py 6.25% 15 Missing ⚠️
paddleformers/trainer/utils/reshard/sharding_v1.py 7.14% 13 Missing ⚠️
paddleformers/trainer/trainer.py 0.00% 7 Missing ⚠️
paddleformers/trainer/utils/reshard/common.py 0.00% 6 Missing ⚠️

❌ Your patch status has failed because the patch coverage (8.88%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2821   +/-   ##
==========================================
  Coverage           ?   28.76%           
==========================================
  Files              ?      335           
  Lines              ?    56450           
  Branches           ?        0           
==========================================
  Hits               ?    16240           
  Misses             ?    40210           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@lugimzzz lugimzzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lugimzzz lugimzzz merged commit ea4fd14 into PaddlePaddle:develop Nov 3, 2025
9 of 16 checks passed
@sneaxiy sneaxiy deleted the cherry_pick_prs branch November 3, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants