Skip to content

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Nov 17, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Others

Description

Fix EMA bug when load different strategies.
Relate to PaddlePaddle/PaddleNLP#11177

@paddle-bot
Copy link

paddle-bot bot commented Nov 17, 2025

Thanks for your contribution!

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (develop@c4e0d1d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...addleformers/trainer/utils/zero_cost_checkpoint.py 0.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #2963   +/-   ##
==========================================
  Coverage           ?   31.41%           
==========================================
  Files              ?      420           
  Lines              ?    68526           
  Branches           ?        0           
==========================================
  Hits               ?    21527           
  Misses             ?    46999           
  Partials           ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Nov 18, 2025
@PaddlePaddle PaddlePaddle unlocked this conversation Nov 18, 2025
@sneaxiy sneaxiy closed this Nov 18, 2025
@sneaxiy sneaxiy reopened this Nov 18, 2025
@sneaxiy sneaxiy requested a review from From00 November 18, 2025 02:11
Copy link
Collaborator

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit e217fcc into PaddlePaddle:develop Nov 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants