Skip to content

[FIX] fix the bug that some gemm config did not be handled #10627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025

Conversation

zeroRains
Copy link
Contributor

@zeroRains zeroRains commented May 21, 2025

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Bug fixes

PR changes

Models

Description

跑模型时出现GEMM 的invalid configure问题

CUDA_VISIBLE_DEVICES=0,1
python -m paddle.distributed.launch --gpus 0,1 predictor.py --model_name_or_path mistralai/Mixtral-8x7B-Instruct-v0.1 --dtype bfloat16 --quant_type weight_only_int8 --mode dynamic --inference_model --append_attn

image

原因:

模型执行时需要先进行gemm configure搜索,在获取的candidate_configure里,paddle中的三个gemm configure没有在dispatch_moe_gemm_to_cutlass中进行处理,导致触发PADDLE_FATAL直接中断执行进程。

修复方案:

  1. 添加缺失的configure处理
  2. 在搜索gemm_configure的相关代码中,用PADDLE_THROW替换PADDLE_FATAL

Copy link

paddle-bot bot commented May 21, 2025

Thanks for your contribution!

yuanlehome
yuanlehome previously approved these changes May 21, 2025
Copy link

codecov bot commented May 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.91%. Comparing base (6f80ea1) to head (f40de2d).
Report is 9 commits behind head on develop.

❌ Your project status has failed because the head coverage (46.91%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10627      +/-   ##
===========================================
- Coverage    46.91%   46.91%   -0.01%     
===========================================
  Files          799      799              
  Lines       132454   132460       +6     
===========================================
  Hits         62138    62138              
- Misses       70316    70322       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuanlehome yuanlehome merged commit 64afc81 into PaddlePaddle:develop May 22, 2025
10 of 12 checks passed
@zeroRains zeroRains deleted the mistral branch May 22, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants