Skip to content

Make sharding_first by default #11059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Sep 8, 2025
Merged

Make sharding_first by default #11059

merged 8 commits into from
Sep 8, 2025

Conversation

@sneaxiy
Copy link
Collaborator

@sneaxiy sneaxiy commented Sep 3, 2025 •
edited
Loading

Before submitting

  • Lint code. If there are lint issues, please format the code first.
# Install and register `pre-commit` in the project folder
pip install pre-commit && pre-commit install

# Process previous code files separately
pre-commit run --file XXXX.py
  • Add test cases into tests folder. If there are codecov issues, please add tests cases first.

PR types

Others

PR changes

Others

Description

Make sharding_first by default.
Cherry-pick #10531.

@paddle-bot
Copy link

paddle-bot bot commented Sep 3, 2025

Thanks for your contribution!

@sneaxiy sneaxiy requested a review from From00 September 6, 2025 03:19
From00
From00 approved these changes Sep 8, 2025
View reviewed changes
Copy link
Collaborator

@From00 From00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sneaxiy sneaxiy merged commit 148206e into PaddlePaddle:develop Sep 8, 2025
10 of 12 checks passed
@sneaxiy sneaxiy deleted the sharding_first branch September 8, 2025 02:49
AlAuAu pushed a commit to AlAuAu/PaddleNLP that referenced this pull request Oct 23, 2025
@sneaxiy @AlAuAu
Make sharding_first by default (PaddlePaddle#11059)
8e11f12 
* make sharding_first by default

* update run_ci.sh

* Update V100 baseline

* Update A100 baselines

* Revert "Update A100 baselines"

This reverts commit c682b27.

* Revert "Update V100 baseline"

This reverts commit 1ca17b7.

* fix topo in CI cases

* fix JSON format error
@sneaxiy sneaxiy mentioned this pull request Oct 30, 2025
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@From00 From00 From00 approved these changes

@tianshuo78520a tianshuo78520a tianshuo78520a approved these changes

Assignees

No one assigned

Labels

skip-ci: distribute-a100 skip-ci: distribute-v100

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sneaxiy @From00 @tianshuo78520a