Add CopperGolemWeatheringEvent #13255
Open
+127
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axyss
force-pushed
the
feat/copper-golem-state-event
branch
from
b1ebdf5 to
8d216ec
Compare
lynxplay
requested changes
Nov 1, 2025
There was a problem hiding this comment.
There are two other ways a copper golem might change its weathering state, one through lightning hit, the other through a player using an axe.
The event definitely needs to be called for these two usecases too.
How we'd expose the lightning or player entity is a bit up in the air.
We could not expose much for now probably tho and down the line (if required and asked for) think about some sealed Cause interface.
paper-api/src/main/java/io/papermc/paper/event/entity/CopperGolemWeatheringEvent.java
Outdated
Show resolved
Hide resolved
github-project-automation
bot
moved this from Awaiting review
to Changes required
in Paper PR Queue
Axyss
force-pushed
the
feat/copper-golem-state-event
branch
from
86ee573 to
4723e34
Compare
Axyss
force-pushed
the
feat/copper-golem-state-event
branch
from
4723e34 to
c54aa9d
Compare
|
A Cause interface sounds good. But yeah, it's probably better to wait. Perhaps a nullable method that exposes the player that triggers the event would suffice for now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the feature described in #13200. Hate the way i'm transforming
WeatheringCopper.WeatherStatevalues intoWeatheringCopperStateones, but I haven't found a cleaner way.