Nettoyage du code

.vscode/settings.json

@@ -12,4 +12,4 @@
     "lint"
   ],
   "typescript.tsdk": "node_modules/typescript/lib"
-}
+}

App.tsx

@@ -10,12 +10,13 @@ import { AccountService } from "@/stores/account/types";
 import { log } from "@/utils/logger/logger";
 import { isExpoGo } from "@/utils/native/expoGoAlert";
 import { atobPolyfill, btoaPolyfill } from "js-base64";
+// eslint-disable-next-line no-duplicate-imports
 import { registerBackgroundTasks } from "@/background/BackgroundTasks";
 import { SoundHapticsProvider } from "@/hooks/Theme_Sound_Haptics";
 import { PapillonNavigation } from "@/router/refs";
 import * as Device from "expo-device";
 import * as ScreenOrientation from "expo-screen-orientation";
-import {getToLoadFonts} from "@/consts/Fonts";
+import { getToLoadFonts } from "@/consts/Fonts";
 import { useFlagsStore } from "@/stores/flags";
 
 SplashScreen.preventAutoHideAsync();
@@ -32,9 +33,9 @@ export default function App () {
   const [appState, setAppState] = useState(AppState.currentState);
   const currentAccount = useCurrentAccount((store) => store.account);
   const switchTo = useCurrentAccount((store) => store.switchTo);
-  const accounts = useAccounts((store) => store.accounts).filter(account => !account.isExternal);
+  const accounts = useAccounts((store) => store.accounts).filter((account) => !account.isExternal);
 
-  const defined = useFlagsStore(state => state.defined);
+  const defined = useFlagsStore((state) => state.defined);
   const [fontsLoaded] = useFonts(getToLoadFonts(defined));
 
   useEffect(() => {
@@ -107,7 +108,7 @@ export default function App () {
           break;
         }
       }
-      await new Promise(resolve => setTimeout(resolve, 1000));
+      await new Promise((resolve) => setTimeout(resolve, 1000));
     }
     await AsyncStorage.removeItem("@background_timestamp");
   }, [currentAccount, switchTo, getBackgroundTimeLimit]);
@@ -166,4 +167,4 @@ export default function App () {
       <Router />
     </SoundHapticsProvider>
   );
-}
+}

babel.config.js

@@ -8,4 +8,4 @@ module.exports = function (api) {
       "react-native-reanimated/plugin"
     ],
   };
-};
+};

eslint.config.js

@@ -2,6 +2,8 @@ const stylistic = require("@stylistic/eslint-plugin");
 const unusedImports = require("eslint-plugin-unused-imports");
 const typescript = require("@typescript-eslint/parser");
 
+const custom_rules = require("./eslint_rules/plugin.js");
+
 module.exports = [
   { // Ignored directory
     ignores: [
@@ -29,15 +31,39 @@ module.exports = [
     },
     plugins: {
       "@stylistic": stylistic,
-      "unused-imports": unusedImports
+      "unused-imports": unusedImports,
+      "custom": custom_rules
     },
     rules: {
       "@stylistic/indent": ["error", 2],
       "@stylistic/no-trailing-spaces": "error",
       "@stylistic/quotes": ["error", "double"],
       "@stylistic/semi": ["error", "always"],
+      "@stylistic/eol-last": ["error", "always"],
       "@stylistic/space-before-function-paren": ["error", "always"],
-      "unused-imports/no-unused-imports": "error"
+      "@stylistic/no-extra-semi": "error",
+      "@stylistic/no-mixed-spaces-and-tabs": "error",
+      "@stylistic/object-curly-spacing": ["error", "always"],
+      "@stylistic/keyword-spacing": ["error", {
+        "before": true
+      }],
+      "@stylistic/arrow-parens": "error",
+      "@stylistic/arrow-spacing": "error",
+      "unused-imports/no-unused-imports": "error",
+      "no-unused-vars": ["error", {
+        "varsIgnorePattern": "^_",
+        "argsIgnorePattern": "^_",
+        "caughtErrorsIgnorePattern": "^_",
+        "destructuredArrayIgnorePattern": "^_"
+      }],
+      "no-var": "error",
+      "no-irregular-whitespace": "error",
+      "no-unneeded-ternary": "error",
+      "no-duplicate-imports": "error",
+      "no-empty": "error",
+      "no-useless-escape": "error",
+      "custom/redundant-logical": "error",
+      "custom/no-redundant-ternary": "error"
     }
   }
 ];

eslint_rules/no-redundant-ternary.js

@@ -0,0 +1,78 @@
+module.exports = {
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Detect and transform nested ternary operators into nullish coalescing chains",
+      category: "Best Practices",
+      recommended: false
+    },
+    schema: [],
+    messages: {
+      redundantNestedTernary: "The nested ternary can be simplified using nullish coalescing operators"
+    },
+    fixable: "code",
+  },
+  create (context) {
+    function processConditionalExpression (node) {
+      const sourceCode = context.getSourceCode();
+
+      // Fonction récursive pour construire la chaîne de nullish coalescing
+      function buildNullishChain (node) {
+        if (node.type !== "ConditionalExpression") {
+          return sourceCode.getText(node);
+        }
+
+        const test = sourceCode.getText(node.test);
+
+        // Si c'est un ternaire imbriqué dans l'alternate
+        if (node.alternate.type === "ConditionalExpression") {
+          // Récupérer l'expression complète du consequent
+          const nextValueNode = node.alternate.consequent;
+
+          // Si c'est un accès à une propriété imbriquée, ajouter l'optional chaining
+          if (nextValueNode.type === "MemberExpression") {
+            const object = sourceCode.getText(nextValueNode.object);
+            const property = sourceCode.getText(nextValueNode.property);
+            return `${test} ?? ${object}?.${property} ?? ${sourceCode.getText(node.alternate.alternate)}`;
+          }
+
+          const nextValue = sourceCode.getText(nextValueNode);
+          return `${test} ?? ${nextValue} ?? ${sourceCode.getText(node.alternate.alternate)}`;
+        }
+
+        return `${test} ?? ${sourceCode.getText(node.alternate)}`;
+      }
+
+      // Vérifie si c'est un cas valide à transformer
+      function isValidTransform (node) {
+        if (!node || node.type !== "ConditionalExpression") return false;
+
+        const test = sourceCode.getText(node.test);
+        const consequent = sourceCode.getText(node.consequent);
+
+        // Soit test et consequent sont identiques
+        if (test === consequent) return true;
+
+        // Soit c'est dans un alternate d'un ternaire valide
+        return !!(node.parent?.type === "ConditionalExpression"
+            && node.parent.alternate === node
+            && isValidTransform(node.parent));
+      }
+
+      // Vérifie si c'est un cas de ternaire imbriqué à transformer
+      if (isValidTransform(node)) {
+        context.report({
+          node,
+          messageId: "redundantNestedTernary",
+          fix (fixer) {
+            return fixer.replaceText(node, buildNullishChain(node));
+          }
+        });
+      }
+    }
+
+    return {
+      ConditionalExpression: processConditionalExpression
+    };
+  }
+};

eslint_rules/plugin.js

@@ -0,0 +1,10 @@
+const redundant_logical = require("./redundant-logical.js");
+const no_redundant_ternary = require("./no-redundant-ternary.js");
+
+const plugin = {
+  rules: {
+    "redundant-logical": redundant_logical,
+    "no-redundant-ternary": no_redundant_ternary
+  }
+};
+module.exports = plugin;

eslint_rules/redundant-logical.js

@@ -0,0 +1,63 @@
+const ts = require("typescript");
+
+module.exports = {
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Detect redundant `x || x.y` or `x && x` patterns",
+      category: "Best Practices",
+      recommended: false
+    },
+    schema: [],
+    messages: {
+      redundantLogical: "The logical expression `{{ expression }}` is redundant. Consider simplifying it."
+    }
+  },
+  create (context) {
+    const parserServices = context.parserServices;
+    if (!parserServices?.program) {
+      return {}; // Ignorer si TypeScript n'est pas activé
+    }
+    const typeChecker = parserServices.program.getTypeChecker();
+
+    return {
+      LogicalExpression (node) {
+        if (node.operator === "&&" || node.operator === "||") {
+          const left = context.getSourceCode().getText(node.left);
+          const right = context.getSourceCode().getText(node.right);
+
+          if (right.startsWith(left)) {
+            const tsNode = parserServices.esTreeNodeToTSNodeMap.get(node.left);
+            const type = typeChecker.getTypeAtLocation(tsNode);
+            const isNullable = (type.getFlags() & ts.TypeFlags.Null) !== 0;
+
+            if ((node.operator === "&&" && isNullable) ||
+                (node.operator === "||" && !isNullable)) {
+              return;
+            }
+
+            // Extraire la partie après le point (ex: pour "x.y", on récupère "y")
+            const suffix = right.slice(left.length);
+
+            context.report({
+              node,
+              messageId: "redundantLogical",
+              data: {
+                expression: `${left} ${node.operator} ${right}`
+              },
+              fix (fixer) {
+                if (node.operator === "&&") {
+                  // Pour &&, utiliser l'opérateur optionnel
+                  return fixer.replaceText(node, `${left}?${suffix}`);
+                } else {
+                  // Pour ||, utiliser l'accès direct
+                  return fixer.replaceText(node, `${right}`);
+                }
+              }
+            });
+          }
+        }
+      }
+    };
+  }
+};

plugins/notifee-mod.js

@@ -1,7 +1,7 @@
 const { withProjectBuildGradle } = require("expo/config-plugins");
 
 module.exports = function withNotifeeRepo (config) {
-  return withProjectBuildGradle(config, async config => {
+  return withProjectBuildGradle(config, async (config) => {
     const contents = config.modResults.contents;
 
     if (!contents.includes("@notifee/react-native")) {
@@ -14,4 +14,4 @@ module.exports = function withNotifeeRepo (config) {
 
     return config;
   });
-};
+};

src/addons/addons.ts

@@ -170,7 +170,7 @@ async function get_addons_list (): Promise<AddonManifest[]> {
         continue;
       }
 
-      manifest.placement.forEach(placement => {
+      manifest.placement.forEach((placement) => {
         placement.main = FileSystem.documentDirectory + "addons/" + addon + "/" + placement.main;
       });
 
@@ -207,9 +207,9 @@ async function get_home_widgets (): Promise<AddonManifest[]> {
 
 async function get_settings_widgets (): Promise<AddonPlacementManifest[]> {
   let addons = await get_addons_list();
-  var res: Array<AddonPlacementManifest> = [];
+  let res: Array<AddonPlacementManifest> = [];
   addons.forEach((addon) => {
-    for (var i = 0; i < addon.placement.length; i++) {
+    for (let i = 0; i < addon.placement.length; i++) {
       if (addon.placement[i].placement == "PLACE_SETTINGS_PAGE")
         res.push({
           index: i,

src/background/BackgroundTasks.ts

@@ -19,33 +19,37 @@ const notifeeEvent = async () => {
 
   // Gestion des badges quand app en arrière-plan
   notifee.onBackgroundEvent(async ({ type, detail }) => {
-    const { notification, pressAction } = detail;
+    const { pressAction } = detail;
 
     switch (type) {
-      case EventType.ACTION_PRESS:
-        console.log(`[Notifee] Action press: ${pressAction?.id}`);
-
-      case EventType.DISMISSED:
+      case EventType.ACTION_PRESS: {
+        log(`[Notifee] Action press: ${pressAction?.id}`, "NOTIFEE/BK");
+        break;
+      }
+      case EventType.DISMISSED: {
         let badgeCount = await notifee.getBadgeCount();
         badgeCount--;
         await notifee.setBadgeCount(badgeCount);
         break;
+      }
     }
   });
 
   // Gestion des badges quand app en premier plan
   notifee.onForegroundEvent(async ({ type, detail }) => {
-    const { notification, pressAction } = detail;
+    const { pressAction } = detail;
 
     switch (type) {
-      case EventType.ACTION_PRESS:
-        console.log(`[Notifee] Action press: ${pressAction?.id}`);
-
-      case EventType.DISMISSED:
+      case EventType.ACTION_PRESS: {
+        log(`[Notifee] Action press: ${pressAction?.id}`, "NOTIFEE/FW");
+        break;
+      }
+      case EventType.DISMISSED: {
         let badgeCount = await notifee.getBadgeCount();
         badgeCount--;
         await notifee.setBadgeCount(badgeCount);
         break;
+      }
     }
   });
 };

src/background/Notifications.ts

@@ -137,8 +137,8 @@ const papillonNotify = async (
       channelId,
       timestamp,
       badgeCount,
-      showTimestamp: channelId !== "Status" ? true : false,
-      showChronometer: channelId === "Status" ? true : false,
+      showTimestamp: channelId !== "Status",
+      showChronometer: channelId === "Status",
       smallIcon: "@mipmap/ic_launcher_foreground",
       color: AndroidColor.GREEN,
       pressAction: {

src/background/data/Homeworks.ts

@@ -27,7 +27,6 @@ const fetchHomeworks = async (): Promise<Homework[]> => {
   if (!firstDate) {
     firstDate = new Date(Date.UTC(new Date().getFullYear(), 8, 1));
   }
-  const firstDateEpoch = dateToEpochWeekNumber(firstDate);
 
   const SemaineAct = dateToEpochWeekNumber(new Date());
   const currentHwSemaineActuelle = getHomeworks()[SemaineAct] ?? [];