Skip to content

Commit 7e74466

Browse files
committed
allow HDF5_VOL_CONNECTOR set before make check/ptest
Exception: when netcdf4 is used, cache and async VOLs are disabled, due to errors coming from those VOLs.
1 parent 32eb394 commit 7e74466

File tree

1 file changed

+21
-6
lines changed

1 file changed

+21
-6
lines changed

test.sh

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,6 @@ mkdir -p ${TESTOUTDIR}
9393
for API in "${APIS[@]}" ; do
9494
ap=($API)
9595

96-
# unset the two VOL environment variables, in case they have been set
97-
unset HDF5_PLUGIN_PATH
98-
unset HDF5_VOL_CONNECTOR
99-
10096
for CONFIG in "${CONFIGS[@]}" ; do
10197
IN_FILE="${srcdir}/datasets/${CONFIG}"
10298
OUT_FILE_BASE="${TESTOUTDIR}/${ap[0]}_${ap[1]}_${CONFIG}"
@@ -105,6 +101,8 @@ for API in "${APIS[@]}" ; do
105101
IN_FILE+=".${FILE_EXT}"
106102
elif test "x${ap[0]}" = xnetcdf4 ; then
107103
FILE_EXT="nc4"
104+
saved_HDF5_PLUGIN_PATH=$HDF5_PLUGIN_PATH
105+
saved_HDF5_VOL_CONNECTOR=$HDF5_VOL_CONNECTOR
108106
if test "x${ap[1]}" = xlog ; then
109107
# This option requires the two VOL environment variables to be set.
110108
export HDF5_PLUGIN_PATH="$LOGVOL_LIB_PATH"
@@ -113,6 +111,8 @@ for API in "${APIS[@]}" ; do
113111
IN_FILE+=".nc"
114112
else
115113
IN_FILE+=".${FILE_EXT}"
114+
unset HDF5_PLUGIN_PATH
115+
unset HDF5_VOL_CONNECTOR
116116
fi
117117
elif test "x${ap[0]:0:4}" = xhdf5 ; then # hdf5, hdf5_log, or hdf5_md
118118
FILE_EXT="h5"
@@ -145,6 +145,11 @@ for API in "${APIS[@]}" ; do
145145
${CMD}
146146
fi
147147

148+
if test "x${ap[0]}" = xnetcdf4 ; then
149+
export HDF5_PLUGIN_PATH=$saved_HDF5_PLUGIN_PATH
150+
export HDF5_VOL_CONNECTOR=$saved_HDF5_VOL_CONNECTOR
151+
fi
152+
148153
# test replay on blob files
149154
if test "x${ap[1]}" = xblob ; then
150155
if test "x${ap[0]}" = xpnetcdf ; then
@@ -185,8 +190,13 @@ for API in "${APIS[@]}" ; do
185190

186191
# for log strategy, check if the output files are log-based VOL files
187192
if test "x${ap[1]}" = xlog ; then
188-
unset HDF5_VOL_CONNECTOR
189-
unset HDF5_PLUGIN_PATH
193+
194+
# disable all VOLs to avoid debug message messing with the output of h5ldump
195+
saved_HDF5_VOL_CONNECTOR=
196+
if test "x$HDF5_VOL_CONNECTOR" != x ; then
197+
saved_HDF5_VOL_CONNECTOR=$HDF5_VOL_CONNECTOR
198+
unset HDF5_VOL_CONNECTOR
199+
fi
190200

191201
for f in ${REAL_OUT_FILE} ; do
192202
echo "CMD = $H5LDUMP -k $f"
@@ -200,6 +210,11 @@ for API in "${APIS[@]}" ; do
200210
echo ""
201211
fi
202212
done
213+
214+
# restore HDF5_VOL_CONNECTOR for next run
215+
if test "x$saved_HDF5_VOL_CONNECTOR" != x ; then
216+
export HDF5_VOL_CONNECTOR=$saved_HDF5_VOL_CONNECTOR
217+
fi
203218
fi
204219

205220
# delete the output files/folder

0 commit comments

Comments
 (0)