Fix failing command line tests #2798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazel-bohon
approved these changes
Apr 12, 2025
danielmarbach
added a commit
that referenced
this pull request
Apr 13, 2025
* No need for double * Fix the bug by forcing the right parameter to be used --------- Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
danielmarbach
added a commit
that referenced
this pull request
Apr 13, 2025
* No need for double * Fix the bug by forcing the right parameter to be used --------- Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
danielmarbach
added a commit
that referenced
this pull request
Apr 13, 2025
* No need for double * Fix the bug by forcing the right parameter to be used --------- Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
danielmarbach
added a commit
that referenced
this pull request
Apr 13, 2025
* No need for double * Fix the bug by forcing the right parameter to be used --------- Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
danielmarbach
added a commit
that referenced
this pull request
Apr 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the failing tests, I discovered that we use a double while SQS only accepts seconds. I switched the parsing logic and the types to consistently use an integer.
While doing that I discovered the root problem, which is default parameter overload resolution makes the verifications sometimes fail
It would probably be nice to have this ported to the current release branch to avoid further failures.