Skip to content

Conversation

@hsvotwa
Copy link
Contributor

@hsvotwa hsvotwa commented Jun 12, 2025

A port of Particular/NServiceBus.Transport.AzureServiceBus#1066

Serializing the arm/disarm actions is not enough. The state transition preceding the arm/disarm action must be captured in the lock as well, otherwise the state transitions could happen properly but then the arm/disarm actions could be executed by the processor in the wrong order, leaving the logic of the circuit breaker itself intact but the consequences of the arm/disarm actions in an incorrect state.

I also added xdoc as a way to document that the arm/disarm actions are called within a lock, and to maybe pave the way for this to be used as a shared component.

@hsvotwa hsvotwa requested review from WilliamBZA and afprtclr June 12, 2025 06:46
@afprtclr
Copy link

license/cla check got stuck and we should get it working. I close and reopen the PR in that case to retrigger it. Please check if that works for you.

@hsvotwa hsvotwa merged commit 71f90c6 into master Jun 18, 2025
4 checks passed
@hsvotwa hsvotwa deleted the repeated-failures-over-time branch June 18, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants