Migrate NUnit assertions to the constraint model in preparation of the NUnit 4 upgrade (#1434)

* Add Nunit.Analyzer to test projects

* Autoformat of test projects for NUnit2001

* Autoformat of test projects for NUnit2002

* Autoformat of test projects for NUnit2003

* Autoformat of test projects for NUnit2004

* Autoformat of test projects for NUnit2005

* Autoformat of test projects for NUnit2007

* Autoformat of test projects for NUnit2018

* Autoformat of test projects for NUnit2019

* Autoformat of test projects for NUnit2045

* Autoformat of test projects for NUnit2046

* Autoformat of test projects for NUnit2048

* Fix remaining warnings and errors

---------

Co-authored-by: danielmarbach <danielmarbach@users.noreply.github.com>

Author: danielmarbach

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/DelayedDelivery/When_deferring_a_message_longer_than_allowed_maximum.cs

@@ -28,7 +28,7 @@ public void Should_throw()
                 .Run());
 
             Assert.That(exception, Is.Not.Null);
-            StringAssert.StartsWith("Message cannot be delayed by", exception.Message);
+            Assert.That(exception.Message, Does.StartWith("Message cannot be delayed by"));
         }
 
         public class Endpoint : EndpointConfigurationBuilder

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/NServiceBus.Transport.RabbitMQ.AcceptanceTests.csproj

@@ -14,6 +14,7 @@
     <PackageReference Include="GitHubActionsTestLogger" Version="2.4.1" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.10.0" />
     <PackageReference Include="NUnit" Version="3.14.0" />
+    <PackageReference Include="NUnit.Analyzers" Version="4.3.0" />
     <PackageReference Include="NUnit3TestAdapter" Version="4.6.0" />
   </ItemGroup>
 

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/QuorumQueues/When_classic_endpoint_uses_quorum_error_queue.cs

@@ -22,8 +22,8 @@ public void Should_fail_to_start()
                 .Done(c => c.EndpointsStarted)
                 .Run());
 
-            StringAssert.Contains("PRECONDITION_FAILED - inequivalent arg 'x-queue-type' for queue 'rabbitmq.transport.tests.quorum-error'", exception.Message);
-            StringAssert.Contains("received none but current is the value 'quorum'", exception.Message);
+            Assert.That(exception.Message, Does.Contain("PRECONDITION_FAILED - inequivalent arg 'x-queue-type' for queue 'rabbitmq.transport.tests.quorum-error'"));
+            Assert.That(exception.Message, Does.Contain("received none but current is the value 'quorum'"));
         }
 
         class ClassicQueueEndpoint : EndpointConfigurationBuilder

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/QuorumQueues/When_classic_endpoint_uses_quorum_queue.cs

@@ -23,8 +23,8 @@ public void Should_fail_to_start()
                 .Done(c => c.EndpointsStarted)
                 .Run());
 
-            StringAssert.Contains("PRECONDITION_FAILED - inequivalent arg 'x-queue-type' for queue 'ClassicEndpointUsesQuorumQueue.ClassicQueueEndpoint'", exception.Message);
-            StringAssert.Contains("received none but current is the value 'quorum'", exception.Message);
+            Assert.That(exception.Message, Does.Contain("PRECONDITION_FAILED - inequivalent arg 'x-queue-type' for queue 'ClassicEndpointUsesQuorumQueue.ClassicQueueEndpoint'"));
+            Assert.That(exception.Message, Does.Contain("received none but current is the value 'quorum'"));
         }
 
         class ClassicQueueEndpoint : EndpointConfigurationBuilder

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/QuorumQueues/When_immediate_retries_with_quorum_queues.cs

@@ -19,10 +19,13 @@ public async Task Should_do_the_configured_number_of_retries()
                 .Done(c => c.ForwardedToErrorQueue)
                 .Run();
 
-            Assert.True(context.ForwardedToErrorQueue);
-            Assert.AreEqual(numberOfRetries + 1, context.NumberOfTimesInvoked, "Message should be retried 5 times immediately");
-            Assert.AreEqual(numberOfRetries, context.Logs.Count(l => l.Message
-                .StartsWith($"Immediate Retry is going to retry message '{context.MessageId}' because of an exception:")));
+            Assert.Multiple(() =>
+            {
+                Assert.That(context.ForwardedToErrorQueue, Is.True);
+                Assert.That(context.NumberOfTimesInvoked, Is.EqualTo(numberOfRetries + 1), "Message should be retried 5 times immediately");
+                Assert.That(context.Logs.Count(l => l.Message
+                    .StartsWith($"Immediate Retry is going to retry message '{context.MessageId}' because of an exception:")), Is.EqualTo(numberOfRetries));
+            });
         }
 
         const int numberOfRetries = 5;

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/QuorumQueues/When_quorum_endpoint_uses_classic_error_queue.cs

@@ -22,8 +22,8 @@ public void Should_fail_to_start()
                 .Done(c => c.EndpointsStarted)
                 .Run());
 
-            StringAssert.Contains("PRECONDITION_FAILED - inequivalent arg 'x-queue-type' for queue 'rabbitmq.transport.tests.classic-error'", exception.Message);
-            StringAssert.Contains("received the value 'quorum' of type 'longstr' but current is none'", exception.Message);
+            Assert.That(exception.Message, Does.Contain("PRECONDITION_FAILED - inequivalent arg 'x-queue-type' for queue 'rabbitmq.transport.tests.classic-error'"));
+            Assert.That(exception.Message, Does.Contain("received the value 'quorum' of type 'longstr' but current is none'"));
         }
 
         class QuorumQueueEndpoint : EndpointConfigurationBuilder

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/QuorumQueues/When_quorum_endpoint_uses_classic_queue.cs

@@ -22,8 +22,8 @@ public void Should_fail_to_start()
                 .Done(c => c.EndpointsStarted)
                 .Run());
 
-            StringAssert.Contains("PRECONDITION_FAILED - inequivalent arg 'x-queue-type' for queue 'QuorumEndpointUsesClassicQueue.QuorumQueueEndpoint'", exception.Message);
-            StringAssert.Contains("received the value 'quorum' of type 'longstr' but current is none", exception.Message);
+            Assert.That(exception.Message, Does.Contain("PRECONDITION_FAILED - inequivalent arg 'x-queue-type' for queue 'QuorumEndpointUsesClassicQueue.QuorumQueueEndpoint'"));
+            Assert.That(exception.Message, Does.Contain("received the value 'quorum' of type 'longstr' but current is none"));
         }
 
         class QuorumQueueEndpoint : EndpointConfigurationBuilder

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/QuorumQueues/When_starting_endpoint_using_quorum_queues.cs

@@ -34,19 +34,19 @@ await Scenario.Define<ScenarioContext>()
                 using (var channel = connection.CreateModel())
                 {
                     var mainQueueException = Assert.Catch<RabbitMQClientException>(() => channel.DeclareClassicQueue(endpointInputQueue));
-                    StringAssert.Contains("PRECONDITION_FAILED - inequivalent arg 'x-queue-type'", mainQueueException.Message);
+                    Assert.That(mainQueueException.Message, Does.Contain("PRECONDITION_FAILED - inequivalent arg 'x-queue-type'"));
                 }
 
                 using (var channel = connection.CreateModel())
                 {
                     var instanceSpecificQueueException = Assert.Catch<RabbitMQClientException>(() => channel.DeclareClassicQueue(endpointInputQueue + "-disc"));
-                    StringAssert.Contains("PRECONDITION_FAILED - inequivalent arg 'x-queue-type'", instanceSpecificQueueException.Message);
+                    Assert.That(instanceSpecificQueueException.Message, Does.Contain("PRECONDITION_FAILED - inequivalent arg 'x-queue-type'"));
                 }
 
                 using (var channel = connection.CreateModel())
                 {
                     var satelliteReceiver = Assert.Catch<RabbitMQClientException>(() => channel.DeclareClassicQueue("QuorumQueueSatelliteReceiver"));
-                    StringAssert.Contains("PRECONDITION_FAILED - inequivalent arg 'x-queue-type'", satelliteReceiver.Message);
+                    Assert.That(satelliteReceiver.Message, Does.Contain("PRECONDITION_FAILED - inequivalent arg 'x-queue-type'"));
                 }
             }
         }

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/When_publishing_message_implementing_interface_in_direct_topology.cs

@@ -29,7 +29,7 @@ public async Task Should_log_a_warning()
                 .Done(c => c.GotTheMessage)
                 .Run();
 
-            Assert.True(context.Logs.Any(l => l.Level == LogLevel.Warn && l.Message.Contains("The direct routing topology cannot properly publish a message type that implements")));
+            Assert.That(context.Logs.Any(l => l.Level == LogLevel.Warn && l.Message.Contains("The direct routing topology cannot properly publish a message type that implements")), Is.True);
         }
 
         public class Publisher : EndpointConfigurationBuilder

src/NServiceBus.Transport.RabbitMQ.AcceptanceTests/When_receiving_a_message.cs

@@ -17,7 +17,7 @@ public async Task Should_have_access_to_BasicDeliverEventArgs()
                 .Done(c => c.MessageReceived)
                 .Run();
 
-            Assert.True(scenario.HandlerHasAccessToBasicDeliverEventArgs, "The handler should have access to BasicDeliverEventArgs");
+            Assert.That(scenario.HandlerHasAccessToBasicDeliverEventArgs, Is.True, "The handler should have access to BasicDeliverEventArgs");
         }
 
         public class Receiver : EndpointConfigurationBuilder