Skip to content

Commit d07d03e

Browse files
Bump Particular/setup-rabbitmq-action from 1.6.0 to 1.7.0 (#1432)
* Bump Particular/setup-rabbitmq-action from 1.6.0 to 1.7.0 Bumps [Particular/setup-rabbitmq-action](https://github.com/particular/setup-rabbitmq-action) from 1.6.0 to 1.7.0. - [Commits](Particular/setup-rabbitmq-action@v1.6.0...v1.7.0) --- updated-dependencies: - dependency-name: Particular/setup-rabbitmq-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Fix flaky tests --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daniel Marbach <danielmarbach@users.noreply.github.com>
1 parent 0b12263 commit d07d03e

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
creds: ${{ secrets.AZURE_ACI_CREDENTIALS }}
5252
enable-AzPSSession: true
5353
- name: Setup RabbitMQ
54-
uses: Particular/setup-rabbitmq-action@v1.6.0
54+
uses: Particular/setup-rabbitmq-action@v1.7.0
5555
with:
5656
connection-string-name: RabbitMQTransport_ConnectionString
5757
tag: RabbitMQTransport

src/NServiceBus.Transport.RabbitMQ.TransportTests/When_changing_concurrency.cs

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ public class When_changing_concurrency : NServiceBusTransportTest
1616
public async Task Should_complete_current_message(TransportTransactionMode transactionMode)
1717
{
1818
var triggeredChangeConcurrency = CreateTaskCompletionSource();
19+
var sentMessageReceived = CreateTaskCompletionSource();
1920
Task concurrencyChanged = null;
2021
int invocationCounter = 0;
2122

@@ -30,6 +31,7 @@ await StartPump(async (context, ct) =>
3031
await task;
3132
}, ct);
3233

34+
sentMessageReceived.SetResult();
3335
await triggeredChangeConcurrency.Task;
3436

3537
}, (_, _) =>
@@ -40,8 +42,10 @@ await StartPump(async (context, ct) =>
4042
transactionMode);
4143

4244
await SendMessage(InputQueueName);
45+
await sentMessageReceived.Task;
4346
await concurrencyChanged;
4447
await StopPump();
48+
4549
Assert.AreEqual(1, invocationCounter, "message should successfully complete on first processing attempt");
4650
}
4751

@@ -62,6 +66,7 @@ await StartPump((context, _) =>
6266
if (context.Headers.TryGetValue("FromOnError", out var value) && value == bool.TrueString)
6367
{
6468
sentMessageReceived.SetResult();
69+
return Task.CompletedTask;
6570
}
6671

6772
throw new Exception("triggering recoverability pipeline");
@@ -84,9 +89,9 @@ await SendMessage(InputQueueName,
8489
transactionMode);
8590

8691
await SendMessage(InputQueueName);
87-
8892
await sentMessageReceived.Task;
8993
await StopPump();
94+
9095
Assert.AreEqual(2, invocationCounter, "there should be exactly 2 messages (initial message and new message from onError pipeline)");
9196
}
9297
}

0 commit comments

Comments
 (0)